Bug 97589 - New selection border style for Slide Layout selection
Summary: New selection border style for Slide Layout selection
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Properties-Layouts
  Show dependency tree / graph
 
Reported: 2016-02-04 22:58 UTC by László Németh
Modified: 2024-03-10 03:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Selected slide layout on Impress sidebar (3.88 KB, image/png)
2016-02-04 22:58 UTC, László Németh 		Details
New selection border on a non-white background. (2.38 KB, image/png)
2016-02-04 22:59 UTC, László Németh 		Details
New selection border on a white background using highlight color of the theme (2.07 KB, image/png)
2016-02-04 22:59 UTC, László Németh 		Details
joined selection and hovering borders (10.11 KB, image/png)
2016-02-04 23:22 UTC, László Németh 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2016-02-04 22:58:00 UTC 
Created attachment 122397 [details]
Selected slide layout on Impress sidebar

Selected slide layout icons have got a 1px selection border (screen shot 1), but other slide previews have got double borders. Depending from the sidebar width, the selection border could be quite different rectangle, than the icon.

The proposed fix draws double border around the icons on a non-white background theme (screen shot 2), and a thick highlight color border directly around the icon on a white background theme (screen shot 3). The border rectangle is similar to the icon shape.
Comment 1 László Németh 2016-02-04 22:59:04 UTC 
Created attachment 122398 [details]
New selection border on a non-white background.
Comment 2 László Németh 2016-02-04 22:59:47 UTC 
Created attachment 122399 [details]
New selection border on a white background using highlight color of the theme
Comment 3 László Németh 2016-02-04 23:21:35 UTC 
Other problem of the old selection: selection and hovering borders can join, resulting 2px line, see screen shot 4
Comment 4 László Németh 2016-02-04 23:22:07 UTC 
Created attachment 122400 [details]
joined selection and hovering borders
Comment 5 Yousuf Philips (jay) (retired) 2016-02-22 21:50:31 UTC 
I remember a similar bug a while ago where someone proposed bringing back the old double border selection for slide layout found in older versions of LO and it was rejected. I searched bug couldnt find it.

@Adolfo, @Stuart: I could have sworn one of you two were involved in that discussion.
Comment 6 Adolfo Jayme Barrientos 2016-02-27 12:39:23 UTC 
Yeah, I know what bug you’re talking about, Jay. I’m too lazy to go find it right now =)

But IMHO László’s approach looks better than what was suggested there, although I’m not a fan of the double border.

I wonder if we could just reuse the appearance of the pressed toolbar buttons for the selected layout and draw that behind the icon. That would look native and modern. Hopefully it’s not something too complicated to achieve :)
Comment 7 Yousuf Philips (jay) (retired) 2016-02-27 18:12:55 UTC 
Whatever is chosen, it would be good to have some unification in the selection border style used in the properties and the slide transitions panels.
Comment 8 QA Administrators 2018-09-27 02:42:17 UTC Comment hidden (noise)
Comment 9 Xisco Faulí 2020-03-09 13:27:50 UTC 
Please add keyword 'needsUXEval' and CC 'libreoffice-ux-advise@lists.freedesktop.org' if input from UX is needed.
Comment 10 QA Administrators 2022-03-10 03:44:38 UTC Comment hidden (noise)
Comment 11 QA Administrators 2024-03-10 03:15:05 UTC Comment hidden (noise)