Bug 96811 - Android Viewer does not focus on the word you search.
Summary: Android Viewer does not focus on the word you search.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Ximeng Zu
URL:
Whiteboard: target:5.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-29 21:18 UTC by Gülşah Köse
Modified: 2017-06-09 14:47 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gülşah Köse 2015-12-29 21:18:41 UTC
1- Open an odt file.
2- Switch to edit mode.
3- Touch search button.
4- Insert a word for searching

If the word you search is not on screen you see, you will see android viewer does not focus on the word.
Comment 1 QA Administrators 2017-03-06 14:03:01 UTC Comment hidden (obsolete)
Comment 2 Ximeng Zu 2017-03-24 02:44:44 UTC
(In reply to Gülşah Köse from comment #0)
> 1- Open an odt file.
> 2- Switch to edit mode.
> 3- Touch search button.
> 4- Insert a word for searching
> 
> If the word you search is not on screen you see, you will see android viewer
> does not focus on the word.

Confirmed. Version 5.4.0.0.alpha0+.
I'd like to try on this issue. Any suggestions are welcome.
Comment 3 Ximeng Zu 2017-03-26 17:30:56 UTC
(In reply to Ximeng Zu from comment #2)
> (In reply to Gülşah Köse from comment #0)
> > 1- Open an odt file.
> > 2- Switch to edit mode.
> > 3- Touch search button.
> > 4- Insert a word for searching
> > 
> > If the word you search is not on screen you see, you will see android viewer
> > does not focus on the word.
> 
> Confirmed. Version 5.4.0.0.alpha0+.
> I'd like to try on this issue. Any suggestions are welcome.

I just submitted a patch.
https://gerrit.libreoffice.org/#/c/35715/

It's sort of a workaround solution. Since a UNO search event doesn't immediately update cursor location, there seems no way to update the viewport according to the cursor location as an atomic operation with the search.
Comment 4 Commit Notification 2017-04-18 11:33:25 UTC
Ximeng Zu committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5333f93a6fd191e424327afe3935f2770a71f620

tdf#96811 Android Viewer doesn't focus on the word you search.

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2017-06-09 09:57:34 UTC
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?