Bug 74636 - FORMATTING: ooo-emphasis-vertical-highlight broken
Summary: FORMATTING: ooo-emphasis-vertical-highlight broken
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.0 beta1
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2014-02-06 21:21 UTC by Luke
Modified: 2018-08-07 16:46 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
PPT file demonstrating bug with vertical highlight (126.00 KB, application/vnd.ms-powerpoint)
2014-02-06 21:21 UTC, Luke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2014-02-06 21:21:10 UTC
Created attachment 93567 [details]
PPT file demonstrating bug with vertical highlight

Steps to Reproduce:

Open an Apache OpenOffice or Microsoft PowerPoint file that uses the custom animation ooo-emphasis-vertical-highlight

Expected Result:
Expand from the middle, while keeping the width constant.

Current Result:
LibreOffice will expand the picture from a dot and then shrink to nothing.

Fixing this bug will help interoperability with Apache OO and MSO.
Comment 1 Jorendc 2014-04-27 12:31:38 UTC
Reproducible, tested using Windows 8.1 with LibreOffice Version: 4.3.0.0.alpha1+
Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f
TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36
Comment 2 Joel Madero 2015-05-12 18:07:50 UTC
Findings:

Regression - worked in 3.3 - bibisect below;

This almost definitely came from major changes in 4.0, updating version to reflect this.

Note: Version 3.6 had other issues but they are unrelated to this bug (image did not show correctly)

 fa7e89899204c70c8bfe421e34a3a9274851eb82 is the first bad commit
commit fa7e89899204c70c8bfe421e34a3a9274851eb82
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Sun Dec 9 20:25:51 2012 +0000

    source-hash-233431e09ef85cb3579e55bd2a8d1f9d7439f8da
    
    commit 233431e09ef85cb3579e55bd2a8d1f9d7439f8da
    Author:     Michael Stahl <mstahl@redhat.com>
    AuthorDate: Wed Jun 27 14:22:20 2012 +0200
    Commit:     Michael Stahl <mstahl@redhat.com>
    CommitDate: Thu Jun 28 14:15:14 2012 +0200
    
        remove obsolete SVX_FRAME_USE_LINEINFO:
    
        the code using that was removed in
        7db30f7aa037f52eb07cbb4fd2796bd869204af8.
    
        Change-Id: I384d4c9850c7a3f2111827407106137ff0f93236

:100644 100644 85f63c5ef6a3f100e2ce8861ea1910a900ee3c3e 7eced3548b6c1ba0f9020d1ef2685f2e3c0d1eb0 M	ccache.log
:100644 100644 14e2b9b93bcc086fd7f97cc37f874a6d401f9e0b 86a4512cc83527a105532e28fede71c226adbf37 M	commitmsg
:100644 100644 c53250a15330543dcdac45df7f352a1998cbf906 863346dfe80e5bfc768f98dac304b78ae56c56ae M	dev-install.log
:100644 100644 d728220497c81f0a39b790d3089bed8b356f8927 bb1072836416490eff491bf477e2254e46086e8e M	make.log
:040000 040000 e04077ccb92260fdf49a5a183c151a4607cab44f 6037d16b116c26c9462e7455e54b1e3d816a6a29 M	opt

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [8f4aeaad2f65d656328a451154142bb82efa4327] source-hash-1885266f274575327cdeee9852945a3e91f32f15
git bisect bad 8f4aeaad2f65d656328a451154142bb82efa4327
# good: [369369915d3582924b3d01c9b01167268ed38f3b] source-hash-45295f3cdceb4c289553791071b5d7f4962d2ec4
git bisect good 369369915d3582924b3d01c9b01167268ed38f3b
# good: [6fce03a944bf50e90cd31e2d559fe8705ccc993e] source-hash-47e4a33a6405eb1b5186027f55bd9cb99b0c1fe7
git bisect good 6fce03a944bf50e90cd31e2d559fe8705ccc993e
# bad: [da317333e5675622f55c9dda17396c659af65320] source-hash-15af925c254f27046427de70a59011e2ac3d6bdb
git bisect bad da317333e5675622f55c9dda17396c659af65320
# bad: [daa21bbd8c7b50e2ca1c2cbed0e39f0e7b5a1cb2] source-hash-6b11a18071254a443c8fe7e7b0b1c95b0f9fd35e
git bisect bad daa21bbd8c7b50e2ca1c2cbed0e39f0e7b5a1cb2
# good: [e270c448410216194de63a2e4c2a16cb6f9a89dd] source-hash-77987eacff20dec40caf29aae61d262239d441e9
git bisect good e270c448410216194de63a2e4c2a16cb6f9a89dd
# good: [0b37d1fca3cd8cd23454122064b8148d343e8903] source-hash-6263315825e01e766668b9ce5d2eb52e71e051a7
git bisect good 0b37d1fca3cd8cd23454122064b8148d343e8903
# bad: [fac2b3e2d91b35320c570b56164e5791020bc42b] source-hash-73202f8edc074ec035255d25ff29bfd4a8d8dfd6
git bisect bad fac2b3e2d91b35320c570b56164e5791020bc42b
# bad: [fa7e89899204c70c8bfe421e34a3a9274851eb82] source-hash-233431e09ef85cb3579e55bd2a8d1f9d7439f8da
git bisect bad fa7e89899204c70c8bfe421e34a3a9274851eb82
# first bad commit: [fa7e89899204c70c8bfe421e34a3a9274851eb82] source-hash-233431e09ef85cb3579e55bd2a8d1f9d7439f8da
Comment 3 Robinson Tryon (qubit) 2015-12-13 11:09:30 UTC Comment hidden (no-value, obsolete)
Comment 4 QA Administrators 2017-01-03 19:50:51 UTC Comment hidden (obsolete)
Comment 5 Luke 2017-01-04 00:51:49 UTC Comment hidden (no-value)
Comment 6 Luke 2017-01-04 00:53:50 UTC Comment hidden (obsolete)
Comment 7 Michael Stahl (allotropia) 2017-01-04 12:49:15 UTC
bibisect range 6263315825e01e766668b9ce5d2eb52e71e051a7..233431e09ef85cb3579e55bd2a8d1f9d7439f8da

the wrong geometry of the animation is a regression from:

commit 372c47309a192e67220913309fa1ccffdff8cde1
Author:     Marco Cecchetti <mrcekets@gmail.com>
AuthorDate: Wed Jun 13 19:50:38 2012 +0200

    Now to animations and repeated to animations are handled by the C++ presentation engine
    as the SMIL spec describes.
Comment 8 Xisco Faulí 2017-01-04 17:13:44 UTC
Adding Cc: to Marco Cecchetti
Comment 9 QA Administrators 2018-01-05 03:41:08 UTC Comment hidden (obsolete)
Comment 10 Mark Hung 2018-08-04 12:16:12 UTC
Verify fixed with current master with the following patch. 

commit 696cbec5c6db783d3dd91d3f7d46f83dcc00b3cc
Author: Mark Hung <marklh9@gmail.com>
Date:   Sat Jul 28 10:56:38 2018 +0800

    tdf#118080 fix formula importing of ppt animation.

    Change-Id: I5f56e0d70a13418b0bde45c2fc65f56fdb365263
    Reviewed-on: https://gerrit.libreoffice.org/58209
    Tested-by: Jenkins
    Reviewed-by: Mark Hung <marklh9@gmail.com>
Comment 11 Xisco Faulí 2018-08-07 16:46:56 UTC
Verified in

Version: 6.2.0.0.alpha0+
Build ID: c86a47a9d3debbc7e8ee6247f573e7f98c611f19
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

@mark Hung, Thanks for fixing this!!!