Bug 156144 - csv file text import dialog stops macro execution in Calc 7.3.7.2
Summary: csv file text import dialog stops macro execution in Calc 7.3.7.2
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.7.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Macro
  Show dependency treegraph
 
Reported: 2023-07-03 13:46 UTC by GroveLn22
Modified: 2023-08-16 17:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
spreadsheet containing macro to import csv data (10.84 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-07-03 14:14 UTC, GroveLn22
Details
csv file for text import to example TST.ods (861 bytes, text/csv)
2023-07-03 14:17 UTC, GroveLn22
Details
Spreadsheet with corrected macro (11.49 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-08-07 12:51 UTC, Samuel Mehrbrodt (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description GroveLn22 2023-07-03 13:46:43 UTC
Description:
Basic macro that worked under Calc version 6.0.7.3 without the need to respond to a dialog popup now requires user to manually click OK in dialog popup to proceed.  For users opening numerous .csv files daily this is a big problem.  Reference bug 74580 for additional discussion.

Steps to Reproduce:
1.See attachments
2.
3.

Actual Results:
.csv dialog popup stops macro execution

Expected Results:
macro execution continues without need to respond to dialog popup


Reproducible: Always


User Profile Reset: No

Additional Info:
Is it possible that .csv dialog was non-modal in version 6.0.7.3 and is modal in version 7.3.7.2 ?

System info:
LibreOffice version 7.3.7.2  Linux 5.15  UI render:default;VCL:gtk3  en-US
Ubuntu package version 1:7.3.7-Oubuntu022.04.3  Calc:threaded
Comment 1 GroveLn22 2023-07-03 14:14:56 UTC
Created attachment 188184 [details]
spreadsheet containing macro to import csv data
Comment 2 GroveLn22 2023-07-03 14:17:26 UTC
Created attachment 188185 [details]
csv file for text import to example TST.ods
Comment 3 raal 2023-07-11 14:37:06 UTC
confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7f1012806f5cf2cd53e52d8f2a95c09a2215efbc
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Works in Version: 5.3.0.0.alpha1+
Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c
Comment 4 raal 2023-07-11 14:46:21 UTC
This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-6.2.
Adding Cc: to Samuel Mehrbrodt ; Could you possibly take a look at this one?
Thanks
 f3c113f21e4829e1926fc8bed494b14ef1fb3e3e is the first bad commit
commit f3c113f21e4829e1926fc8bed494b14ef1fb3e3e
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Jun 19 14:25:28 2018 +0200

    source 1115a60e6d825c049680e7f2caf318e36d481b12

56086: tdf#118238 Only disable UI interaction when loading document as hidden | https://gerrit.libreoffice.org/c/core/+/56086
Comment 5 Samuel Mehrbrodt (allotropia) 2023-08-07 12:50:45 UTC
Not really a regression.
You are loading a document via loadComponentFromURL, and there is no guarantee that no dialog pops up there.

If you want to restore the old behavior, you need to set the "Hidden" attribute [1]of the MediaDescriptor to true.

I will upload your file with this attribute added.

[1] https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1document_1_1MediaDescriptor.html#a1922b1bc53179cdff4d220977a130e15
Comment 6 Samuel Mehrbrodt (allotropia) 2023-08-07 12:51:47 UTC
Created attachment 188829 [details]
Spreadsheet with corrected macro
Comment 7 GroveLn22 2023-08-16 17:11:22 UTC
corrected macro works great!  Thank you Samuel Mehrbrodt & raal