Created attachment 129098 [details] sample Steps: 1. Open attached document Observed behaviour: Numbering in second level in page 2 is incorrect Reproduced in Version: 5.3.0.0.alpha1+ Build ID: 4ebf1ea7cb66fc3e6b94cd38dd233aaead69f3d5 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout Engine: old; Locale: ca-ES (ca_ES.UTF-8); Calc: group but not in Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e
Regression introduced by: author Oliver-Rainer Wittmann <orw@apache.org> 2014-07-01 15:20:58 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2014-07-02 09:46:47 (GMT) commit fa0421c763a92dbfead1d0144b434a3b6ab9dccb (patch) tree f02c0c1ccdb24ca4cc8c6e7de03c83ea43503218 parent 9fb4cf25cf25b565058baff74af40398127c4083 (diff) Related: #i78498# some further improvements and corrections for outlines - apply default outline level to WW8 Build-in Heading Styles - get WW8 Build-In Heading Styles' list level applied to the paragraphs - apply list level properties of WW8 Built-In Heading Styles only, if the list level of the WW8 Build-In Heading Style corresponds to its outline level (cherry picked from commit 90ea610040acc8cc2ae66e774aff11b0bafcc59c) (cherry picked from commit 2b0eadc3a706a2b2b41c48caa4f01691978f1190) Conflicts: sw/source/filter/ww8/ww8par.cxx sw/source/filter/ww8/ww8par2.cxx sw/source/filter/ww8/ww8par2.hxx sw/source/filter/ww8/ww8par3.cxx
Created attachment 129675 [details] sample2
Faced same bug, Works fine with <=4.3 and stop working with =>4.4
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
still repro in Version: 6.1.2.1 Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 4; OS: Windows 6.1; UI render: default; Locale: ru-RU (ru_RU); Calc: group threaded
Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
So 6.3.2 and the bug is surprisingly here. :)
Created attachment 154642 [details] comparison MSO 2010 and LibreOffice 6.4 Master
Still reproducible in Version: 6.4.0.0.alpha0+ Build ID: d5b7627a0e738c0866b819910153b96b611813f8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded
@Justin Luth, I thought you might be interested in this issue...
*** This bug has been marked as a duplicate of bug 94326 ***
Not a duplicate. test_docx_filter_multilevel_numbering.doc has a different problem from bug 94326 - an inheritance problem. It inherits from Heading 2. So in Word it would be at level 2, but in Writer, there is no level inheritance from "Chapter Numbering" styles - so in this case a special effort would need to be made to copy the OutlineLvl setting from the parent style, I think.
In test_numerotation.doc, Titre 1 (heading 1) really does not specify a numbering list (sprmPIlfo) or a listlevel (sprmPIlvl), only an outline level (sprmPOutLvl). So there is no numbering associated with this style. Instead, the numbering is applied directly on all four paragraphs using sprmPIlfo listId 1. Titre 2 specifies outlineLevel 1 (aka 2), ListLevel 1 (aka 2), and listId 1 (same as the heading1 paragraphs). That causes a problem, because LO uses a secret, internal list for Chapter Numbering (Heading 2-10) which is not available for Direct Properties. (I think there is a way for numbering styles to share a list - which is how this would have to play out.)
*** Bug 120396 has been marked as a duplicate of this bug. ***
*** Bug 75748 has been marked as a duplicate of this bug. ***
A number of changes happened in 4.4. It is important to pay attention to the actual second level numbering. It is more than just "two digits showing" - they need to follow the first level section numbers and not just be 1.x all the way through the document. A better bibisect for test_numerotation.doc is an earlier commit by author Oliver-Rainer Wittmann on 2014-06-30 09:46:15 +0100 commit c99f264be5eaf481f88606e2606c34170675c1b4 Related: #i78498# improvements/corrections regarding outline level & Co - import outline level attribute at Paragraph Styles - import outline level attribute at paragraphs - refactor code to apply list level properties to Outline Style -- only consider WW8 list styles applied to WW8 Built-in Heading Styles -- only assign our counterparts of WW8 Built-in Heading Styles to Outline Style https://cgit.freedesktop.org/libreoffice/core/commit/?id=c99f264be5eaf481f88606e2606c34170675c1b4
proposed fix at http://gerrit.libreoffice.org/c/core/+/117745 tdf#104239 doc import: accept outlineLvl0 == (listLvl = MAXLEVEL) and https://gerrit.libreoffice.org/c/core/+/117746 tdf#104239 doc import: use "Outline" for m_pChosenWW8OutlineStyle
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8bfa14e831f31f372b98d7283fa4abc73bcb5532 tdf#104239 doc import: accept outlineLvl0 == (listLvl = MAXLEVEL) It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/27aedd8f7de6f94469ab515cf0ab0c7e85550efc tdf#104239 doc import: use "Outline" for m_pChosenWW8OutlineStyle It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f5394ceda7e714b87050d78a0319dc3cfab9ac99 tdf#104239 doc import: chose m_pChosenWW8OutlineStyle carefully It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5f9fb51ba84619c60f304afda76a013a8f3dc14c tdf#104239 doc import: listLevel 9 is body text It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e5ac6caf9efa3d3a8cb82dbc59ef00b193facdc4 tdf#104239 doc import: fix chose m_pChosenWW8OutlineStyle carefully It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
test_numerotation.doc: comment 0: fixed numbering.doc: comment2: not fixed. numbering_increase.doc: comment 14: fixed 75748 test1 MS2010.doc: comment 15: fixed
Created attachment 173310 [details] numbering_DUMP.doc: illustrated doc-dumper detail of comment 2's example document. (In reply to Justin L from comment #23) > numbering.doc: comment2: not fixed. This is a fairly simple document (surprisingly) and can be "fixed" by not doing any chapter numbering at all. It only uses LFO 8 (and LFO 0). Only styles Heading 1 and Heading 2 define an LFO (8 of course). In the body text, it uses LFO 0 to cancel numbering on some heading styles, and it specifies LFO8 along with listLvl 2 (aka level 3) on the (Heading 2) paragraphs that are missing the numbering. The reason the numbering is missing is because Chapter Numbering has an empty slot for Level 3. That is really tricky though - to evaluate the entire body of text to see if m_pChosenWW8OutlineStyle is in use before accepting it. One option would be to ONLY accept LFO 1 as m_pChosenWW8OutlineStyle, but that is pretty drastic. P.S. numbering.doc is a good counter-check to use with any fixes for bug 130670.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/26af8b14aad463ea7f1fd22ac221269f23145855 tdf104239 doc import: re-arrange aPreventUseAsChapterNumbering It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17bc5794d6acd38304653dc78b95f9f772893ca7 tdf#104239 doc import CN: don't skip no-style levels It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I set Verified for sample and duplicates, DOC and DOCX. Very great from Justin. Thanks.
(In reply to Justin L from comment #23) > numbering.doc: comment2: not fixed. Just for the record, this was fixed (and added as a unit test) by comment 26.