Bug 138517 - Display keyboard shortcut "Ctrl+U" again for menu Format > Text > Single Underline
Summary: Display keyboard shortcut "Ctrl+U" again for menu Format > Text > Single Unde...
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4 all versions
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2020-11-26 21:12 UTC by Ming Hua
Modified: 2024-05-23 06:34 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-11-26 21:12:24 UTC
Just like bug 138000, after the change of uno:Underline to uno:UnderlineSingle in

https://git.libreoffice.org/core/+/431950e1eade91f8587d3ecffa73fd09136e16b6

tdf#121239 give writer, calc and draw/impress the same underline options

... the reminder of keyboard shortcut "Ctrl+U" disappeared along with the menu icon, likely because Ctrl+U is assigned to uno:Underline, not uno:UnderlineSingle.

Of course, the shortcut still works, it's just the reminder is not displayed on menu anymore.
Comment 1 Ming Hua 2020-11-26 21:13:50 UTC
I don't think bibisection is needed as the root cause should be identical to bug 138000.
Comment 2 Roman Kuznetsov 2021-08-04 17:15:22 UTC
confirm in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Gabor Kelemen, could you please look at it?
Comment 3 Justin L 2021-11-27 11:54:26 UTC
Proposed patch at http://gerrit.libreoffice.org/c/core/+/125940

The identified commit was actually made and approved by Caolan (not Gabor).
Comment 4 Ming Hua 2021-11-28 02:49:33 UTC
(In reply to Justin L from comment #3)
> Proposed patch at http://gerrit.libreoffice.org/c/core/+/125940
Thanks for taking interests in this, Justin.

> The identified commit was actually made and approved by Caolan (not Gabor).
I believe it was assigned to Gabor because he had a patch in
https://gerrit.libreoffice.org/c/core/+/120093
But he didn't like his approach there and wanted to think more, and therefore didn't commit it.
Comment 5 Justin L 2021-11-29 05:50:20 UTC
Gabor notes in his patch that currently the toolbar/sidebar shows "Ctrl-U" when hovering over the underline meta-button. That is good, and very visible for the average GUI user. It would be a shame for that to go missing - and it does go missing when the shortcut is reassigned to UnderlineSingle.

Perhaps looking at how "unordered lists" handles this would be helpful. It too is an option, and yet in the format - lists - unordered list it is just a single entry.
Comment 6 Justin L 2021-11-29 06:13:45 UTC
(In reply to Justin L from comment #5)
> Perhaps looking at how "unordered lists" handles this would be helpful.
No that doesn't help much. It DOES show Ctrl-U and it IS just a regular menu entry, But it shows both Underline and UnderlineDouble as ON when double-underline is chosen (the whole reason for the commit in comment 0).
Comment 7 Gabor Kelemen (allotropia) 2021-11-29 20:14:02 UTC
(In reply to Justin L from comment #6)
> (In reply to Justin L from comment #5)
> > Perhaps looking at how "unordered lists" handles this would be helpful.
> No that doesn't help much. It DOES show Ctrl-U and it IS just a regular menu
> entry, But it shows both Underline and UnderlineDouble as ON when
> double-underline is chosen (the whole reason for the commit in comment 0).

Hi Justin

I think we should just set this as NAB.

If we don't want to show an Underline command in the menu which is enabled alongside the Single Underline AND the Double Underline commands, we must accept that the Ctrl-U shortcut belongs to the Underline command which is visible only on the toolbar/sidebar.
Comment 8 Ming Hua 2021-11-30 02:22:06 UTC
It seems impossible to have "Ctrl+U" shortcut reminder for both menu entry and toolbar icon.  And since the user can add .uno:Underline to menu himself via "Tools > Customize..." dialog, "Menu" tab, and once added, the new menu entry will be labelled as "Underline  Ctrl+U" with shortcut correctly displayed, I agree it's probably best to just resolve this bug as NAB.