Bug 161151 - Complete the renaming of "Quadratic" and "Square" gradient types for transparency
Summary: Complete the renaming of "Quadratic" and "Square" gradient types for transpar...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium minor
Assignee: Stéphane Guillou (stragu)
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Object-Fill-Gradient
  Show dependency treegraph
 
Reported: 2024-05-17 13:03 UTC by Tuomas Hietala
Modified: 2024-06-06 06:29 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2024-05-17 13:03:14 UTC
Description:
Some time ago, a gradient type in LO was renamed from "Quadratic" to "Square (Quadratic)" and another gradient type, "Square" was renamed to "Rectangular". 

There are still two UI strings were the old (and confusing) names are still in use, though. These should be changed, too.

Steps to Reproduce:
1. See https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=a8b049d59ebb4cae and https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=2878024b74d39a49


Actual Results:
The old names are in use in two UI strings.

Expected Results:
The remaining strings are converted to the new naming scheme.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Stéphane Guillou (stragu) 2024-06-03 15:12:26 UTC
Confirmed, this applies to the transparency gradients. I see the mismatch between dialog and sidebar in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

True since fix 790dc4d759c3a2f7f7fc513d358cc0e116e6f17a for bug 154071.
Comment 2 Stéphane Guillou (stragu) 2024-06-04 23:52:03 UTC
Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/168415
Comment 3 Commit Notification 2024-06-06 06:28:59 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4e21f1df31b6e792490f67178aefae370a91ffb7

tdf#161151 finish renaming gradient geometries in sidebar

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.