Created attachment 159709 [details] no text selected for right mouse button libreoffice-writer-6.4.1.2-1.fc33.x86_64 oowriter right-click on empty area of the page Character->Character... HyperLink URL http://www.example.com ("Text:" field remains empty) OK Nothing happens. Document remains unmodified. "http://www.example.com" gets lost. There should be some warning trying to set hyperlink for no object / no text. This makes Bug 132150 more annoying.
Created attachment 159710 [details] Hyperlink dialog with no "Text:" entry
Even if you insert text, this text won't be displayed in the document (same bug or another bug?) If you insert hyperlink without text with Insert => Hyperlink the hyperlink is displayed (could also be an option for hyperlink tab of the character dialog. To be hinest, I wasn't aware of this option in character dialog (and I also don't know, if it is needed here) cc: Design-Team for further input for a desired solution I change status to NEW
Insert > Hyperlink: foo.com (without text) adds foo.com to the document, with text the it's inserted with the link. Tested with 6.3 on a new and blank document. What's the difference?
(In reply to Heiko Tietze from comment #3) > Insert > Hyperlink: foo.com (without text) adds foo.com to the document, > with text the it's inserted with the link. Tested with 6.3 on a new and > blank document. What's the difference? Heiko, this bug is not about the hyperlink dialog, but about hyperlink tab in character dialog. I wouldn't expect such a tab there (paragraph dialog hasn't got it).
The Hyperlink tab shouldn't be there at all. The item "Character" is about applying a style to characters and a hyperlink is no style but content. In case it has been intended to allow to set the style of a hyperlink while creating a hyperlink, that can go to the hyperlink dialog.
So we either remove the tab completely (+1 for this) or make the text field working. Meaning if you apply the formatting to some selection it contains the text but is disabled. If the field is editable and empty you have to insert some text. I would block the Ok button until this condition is met. Jan, would you agree with removing the hyperlink tab?
(In reply to Heiko Tietze from comment #6) > So we either remove the tab completely (+1 for this) +1 from my side. Hperlink dialog also provides more options (for exaple link to other documents).
(In reply to Heiko Tietze from comment #6) > Jan, would you agree with removing the hyperlink tab? I was expecting to just hide/disable the Hyperlink tab in the Character dialog iff there is no text selected. I had to discover there exists the Insert->Hyperlink possibility. Yes, it makes some sense that the hyperlink is "inserted", I was more searching how to "Format" an existing text to add a hyperlink to it.
So let's get rid of it. UI-wise we could hide the tab but I wonder what code lingers behind.
The hyperlink tab is the only way to change the appearance of links, see bug 138292. So we have to consider the two options, somehow.
It should be possible to integrate the options from the hyperlink tap inside the hyperlink dialog. +1 to remove
Hyperling tab still here in Character - Character. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a082762fb3f41237df6385ab27f7a75d6ff92690 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/63315d601296f7c188e920f73b12260d018807d0 Resolves tdf#132253 - Remove hyperlink tab from character dialog It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Now that's done, we also need to purge the relevant documentation page. https://help.libreoffice.org/24.8/en-US/text/shared/01/05020400.html
(In reply to Stéphane Guillou (stragu) from comment #14) > Now that's done, we also need to purge the relevant documentation page. > https://help.libreoffice.org/24.8/en-US/text/shared/01/05020400.html Sure, but don't we also still need something to be added to the 'Hyperlink...' dialog for formatting or manipulating style of the link? With tab removed from the Character dialog, some way to define/edit the 'Internet Link' and 'Visited Internet Link' *styles* being applied on insert (or conversion) with the dialog. Styles which BTW remain on the "Character Styles" of the Stylist.
(In reply to V Stuart Foote from comment #15) > Sure, but don't we also still need something to be added to the > 'Hyperlink...' dialog for formatting or manipulating style of the link? You can change the CS via the Stylist. I don't think we need user-defined CS for links beyond the two standards. And Regina has good arguments in comment 5 against entwisting the two.
(In reply to Heiko Tietze from comment #16) > You can change the CS via the Stylist. I don't think we need user-defined CS > for links beyond the two standards. And Regina has good arguments in comment > 5 against entwisting the two. In general, I agree with simplifying. We already have too many, conflicting ways to change the look of hyperlinks (Application Colours, direct editing of corresponding character style). The now-defunct Character dialog's Hyperlink tab allowed assigning a different character style for visited/unvisited hyperlinks _per selected text run_, which is a very niche use. If anything, it should be a feature of Paragraph Styles... If we are OK with saying goodbye to this functionality, we'd also need to get rid of the obsolete code. Heiko, Regina, do you know if this kind of functionality is supported in e.g. MSO? i.e., are we sure we are not removing some interoperability? Or removing some ODF-supported feature?
(In reply to Stéphane Guillou (stragu) from comment #17) > If anything, it should be a feature of > Paragraph Styles... (hot take, really unsure about this one)
(In reply to Stéphane Guillou (stragu) from comment #17) > The now-defunct Character dialog's Hyperlink tab allowed assigning a > different character style for visited/unvisited hyperlinks _per selected > text run_, which is a very niche use. According the Styles Inspector it is DF with the attributes "Unvisited CS Name" and "Visited CS Name" bound to the CS "Internet Link" and "Visited Internet Link". ODF states: 19.880.2 <text:a> The text:style-name attribute specifies a text style for an unvisited hyperlink.... The text:style-name attribute has the data type styleNameRef 18.3.32. 19.907 text:visited-style-name The text:visited-style-name attribute specifies a style for a hyperlink that has been visited. (Quite unclear to me; there is no "text:unvisited-style-name" neither some text:a description for visited hyperlinks)
Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/db688bf5d40a94939f8e6ab35744c267d35b39ab tdf#132253 Hyperlink tab in Characters is gone.