Bug 96643 - Standard toolbar isn't fully shown under gtk3
Summary: Standard toolbar isn't fully shown under gtk3
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.2.0
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2015-12-21 12:53 UTC by Maxim Monastirsky
Modified: 2016-10-25 19:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Monastirsky 2015-12-21 12:53:26 UTC
Similar to Bug 94757. When starting Writer under gtk3, the last button of the standard toolbar ("Show Draw Functions") isn't visible.

bisect range is:
http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=42645fe67cac22e9a96bc4b34c4f85c09185d9d2..6b57529888f384307b88cf5ead5e3e477c6c03b1

This one looks suspicious:

commit 60e67b387e79185a33eb07bc03b01cd6d0d0a56b
Author: Noel Grandin <noel@peralex.com>
Date:   Fri Dec 18 10:08:35 2015 +0200

    fix O(n^2) in vcl event broadcasting tdf#90199
    
    Change-Id: If3d7514364589058334369432cdcf4f7586c239d

@Noel: Hi, Any chance you could take a look, please?
Comment 1 Maxim Monastirsky 2015-12-21 13:01:00 UTC
Actually Bug 94827 is also reproducible again now.
Comment 2 Commit Notification 2015-12-22 07:55:22 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c4f513b64ff6c8bd09d944a462549cd3842fcfcb

tdf#96643 - Standard toolbar isn't fully shown under gtk3

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.