Bug 94876 - loading from WKS format
Summary: loading from WKS format
Status: RESOLVED FIXED
Alias: None
Product: Document Liberation Project
Classification: Unclassified
Component: General (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: x86 (IA32) All
: medium normal
Assignee: osnola
URL:
Whiteboard: libwps bibisected
Keywords: bisected, regression
Depends on:
Blocks:
 
Reported: 2015-10-08 09:12 UTC by Denis K
Modified: 2016-02-23 06:21 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot and example of *.wks to load (107.43 KB, application/zip)
2015-10-08 09:12 UTC, Denis K
Details
screenshot (121.75 KB, image/jpeg)
2015-10-16 08:15 UTC, David Tardon
Details
sample spreadsheet (9.53 KB, application/vnd.lotus-1-2-3)
2015-10-16 08:15 UTC, David Tardon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Denis K 2015-10-08 09:12:04 UTC
Created attachment 119408 [details]
screenshot and example of *.wks to load

Hello.
Libre Office Calc incorrectly loads data from WKS-file (in attachment). 
See screenshot in attachment - all data in the column "barcode" are wrong.
MS Office Excel 2003 loads this file correctly.
Comment 1 Buovjaga 2015-10-09 14:24:38 UTC
Confirmed.

Works OK in 4.3.0.1, so regression.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

Version: 5.1.0.0.alpha1+
Build ID: f830600ece806ec365a4839e79afabe183c5e36d
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-06_22:49:09
Locale: en-US (fi_FI)
Comment 2 raal 2015-10-14 11:59:35 UTC
bibisect-win32-5.0, oldest version contains bug too.
git checkout oldest: Version: 4.5.0.0.alpha0+
Build ID: 57d6b92b69a31260dea0d84fcd1fc5866ada7adb
Comment 3 David Tardon 2015-10-16 08:14:40 UTC
I observe the same problem in 4.3 built with system libwps 0.3.1. So the bug first appeared in that version.
Comment 4 David Tardon 2015-10-16 08:15:17 UTC
Created attachment 119666 [details]
screenshot
Comment 5 David Tardon 2015-10-16 08:15:50 UTC
Created attachment 119667 [details]
sample spreadsheet
Comment 6 raal 2015-11-29 16:26:08 UTC
This seems to have begun at the below commit.
Adding Cc: to Maxim Monastirsky ; Could you possibly take a look at this one?
Thanks
 9eb6d29a186b297c94553d17aeeba03bb58b0e75 is the first bad commit
commit 9eb6d29a186b297c94553d17aeeba03bb58b0e75
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 00:09:55 2015 +0800

    source-hash-e5ac048af125e82829d353ec031c99e96572e2c0
    
    commit e5ac048af125e82829d353ec031c99e96572e2c0
    Author:     Maxim Monastirsky <momonasmon@gmail.com>
    AuthorDate: Sun Aug 3 15:51:51 2014 +0300
    Commit:     Maxim Monastirsky <momonasmon@gmail.com>
    CommitDate: Sun Aug 3 15:52:41 2014 +0300
    
        Fix calc_MS_Works_Document extensions
    
        Change-Id: Icbf087464997561b09c7b43c2269eea2c8c603bb
Comment 7 Maxim Monastirsky 2015-11-29 16:48:44 UTC
(In reply to raal from comment #6)
> This seems to have begun at the below commit.

>     commit e5ac048af125e82829d353ec031c99e96572e2c0
>     Author:     Maxim Monastirsky <momonasmon@gmail.com>
>     AuthorDate: Sun Aug 3 15:51:51 2014 +0300
>     Commit:     Maxim Monastirsky <momonasmon@gmail.com>
>     CommitDate: Sun Aug 3 15:52:41 2014 +0300
>     
>         Fix calc_MS_Works_Document extensions
>     
>         Change-Id: Icbf087464997561b09c7b43c2269eea2c8c603bb

What happened in this commit, is that the libwps based filter now loads the file instead of the LO internal lotus filter - which still loads the file correctly if forcing it (by selecting "Lotus 1-2-3" type in the open dialog).
Comment 8 osnola 2015-11-30 08:06:46 UTC
Hello,
concerning libwps, I find the cause of this problem of precision and I commit https://sourceforge.net/p/libwps/code/ci/394f21a421754d047f2802b8a2c13fbb44e593ff/ to fix it ( a fix which will happen in libwps-0.4.3 :-~ )