Bug 92314 - PERF: Open file, CPU at 100%
Summary: PERF: Open file, CPU at 100%
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.2.2 release
Hardware: x86-64 (AMD64) All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks:
 
Reported: 2015-06-24 15:57 UTC by raal
Modified: 2016-04-10 15:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2015-06-24 15:57:24 UTC
Steps to reproduce:
open attachment https://bugs.documentfoundation.org/attachment.cgi?id=93901  from bug 50572
click somewhere in the document
CPU load 100%, unable to work with file

Tested with Version: 5.1.0.0.alpha1+
Build ID: a64999511ae654131d997eec9a3d78478cfc1c75
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-22_05:01:17
and LO 4.4.2.2

Works correct with LO 3.5,regression
Comment 1 m_a_riosv 2015-06-24 22:32:52 UTC
Hi @raal,

reproducible with several versions beginning with 3.6

Version: 5.0.0.1 (x64)
Build ID: 9a0b23dd0ab9652e0965484934309f2d49a7758e
Version: 5.1.0.0.alpha1+ (x64)
Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53
Comment 2 Michael Weghorn 2015-07-17 21:05:12 UTC
bibisect result (using bibisect-43all repository):
 3df91c208de9113ce991e71bb67f175b01f804c8 is the first bad commit
commit 3df91c208de9113ce991e71bb67f175b01f804c8
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Sun May 11 00:20:05 2014 +0000

    source-hash-396b3594feb735e1a9cd1564f28340d514f9d925
    
    commit 396b3594feb735e1a9cd1564f28340d514f9d925
    Author:     Tsutomu Uchino <hanya@apache.org>
    AuthorDate: Wed Jan 8 08:36:06 2014 +0000
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Wed Jan 8 10:33:20 2014 +0000
    
        Resolves: #i118909# fix empty elements of return value...
    
        in UICategoryDescription::getElementNames
    
        (cherry picked from commit e4eb014761df0bd5c88acbcee1935743cb2a04e0)
    
        Change-Id: Ib5a2e14ecb446c339afe5e53be435478845a4024

:100644 100644 05cb5ac747f90e8e3dc7d17919e9b39307b51874 02a3d23704cc479bd32d457eb432982f9ce283f4 M	ccache.log
:100644 100644 cc2de8eaea591d06bc74e4c1665b111413945171 3fed867c3434f93c8a6aeaf5ff0dbdcba47090d4 M	commitmsg
:100644 100644 026258867556299f083e33a691c30fa6ba1ea358 816d1ec83caf9a104b473fe7f8dc9cd186b5d720 M	make.log
:040000 040000 d11a9a31c6d5e5f3761ac42864141a489ff43de9 428a4fdc97569110da3422b36c1b67d5c0a1e037 M	opt

---

$ git bisect log
# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# good: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect good 4850941efe43ae800be5c76e1102ab80ac2c085d
# skip: [a900e72b6357882284c5955bdf939bf14269f5fb] source-hash-dd1050b182260a26a1d0ba6d0ef3a6fecc3f4e07
git bisect skip a900e72b6357882284c5955bdf939bf14269f5fb
# skip: [3dda83fc3a43afc6af7f5c0ffd029e610ec1b9a3] source-hash-c59b3d6c5c8096486730007d9b9b053793b90b1e
git bisect skip 3dda83fc3a43afc6af7f5c0ffd029e610ec1b9a3
# bad: [4f705a8cfb1998b09f2062510b207d35a33647d8] source-hash-1eeb20f3958666ec6ba6e0fcf52e92e5eb447a14
git bisect bad 4f705a8cfb1998b09f2062510b207d35a33647d8
# bad: [3c72d6d27e2a0c420f74941355400b0834c550bb] source-hash-c30677731c55688c764a669ecea1b1c4d17ae57d
git bisect bad 3c72d6d27e2a0c420f74941355400b0834c550bb
# bad: [92457a48f3715b1233ea025387627280dae681b0] source-hash-c1503da35d8879366da13258837cf0084a536809
git bisect bad 92457a48f3715b1233ea025387627280dae681b0
# skip: [bde12e7d6eef3d657ebdf62cb5442490fb90d899] source-hash-03725013b64e74473e1a9e925b24927e7e61d412
git bisect skip bde12e7d6eef3d657ebdf62cb5442490fb90d899
# bad: [0d4c20a601a3cfff27d6685d0e81463086bd9d74] source-hash-f1b1e73227471192682d303a58618ca8bd65a74d
git bisect bad 0d4c20a601a3cfff27d6685d0e81463086bd9d74
# bad: [77962b3d9a08d8c7177b2c67da6ed1c5bc26572c] source-hash-d1ba55a28cd40134356faf3e01971491086591d9
git bisect bad 77962b3d9a08d8c7177b2c67da6ed1c5bc26572c
# bad: [6b545103ded12a7a1e7b490734eb094344a0f3ca] source-hash-76702bc75d79dee09a01c57c68e49efa5664c355
git bisect bad 6b545103ded12a7a1e7b490734eb094344a0f3ca
# bad: [3df91c208de9113ce991e71bb67f175b01f804c8] source-hash-396b3594feb735e1a9cd1564f28340d514f9d925
git bisect bad 3df91c208de9113ce991e71bb67f175b01f804c8
# good: [4c250572ae8c8781a5818604af20125e9d992030] source-hash-52263eb4ee841ff101fa54e7fb95d76d2070f91b
git bisect good 4c250572ae8c8781a5818604af20125e9d992030
# first bad commit: [3df91c208de9113ce991e71bb67f175b01f804c8] source-hash-396b3594feb735e1a9cd1564f28340d514f9d925
Comment 3 Matthew Francis 2015-09-03 03:15:12 UTC
Narrowed this down somewhat to the range 45c537a1185dfca7e51229dde9e9220e5174bd57~1..e1b14fa6557f0ded8b5149e28e00861b296dcb34

Ignoring obviously irrelevant commits leaves the following candidates:


commit b4ea08def28a510212f4de355b384e8542c014d4
Author: Kohei Yoshida <kohei.yoshida@collabora.com>
Date:   Mon Jan 6 12:45:43 2014 -0500

    Try not to use ScDocument as a "anything can go in" storage place.
    
    There are things that shouldn't be stored in ScDocument believe it or
    not.
    
    Change-Id: I6a06327549851fae0fdc0defbc716285d8456aa2

commit 4a7a6b46c0dc779581f271b9e6c13c365eca7ab8
Author: Kohei Yoshida <kohei.yoshida@collabora.com>
Date:   Mon Jan 6 16:12:28 2014 -0500

    fdo#73001: Simplify the selection function logic & calculate correct results.
    
    Fixing a bug and cleaning up the code all at the same time.  And don't forget
    to write test for it as well.
    
    Change-Id: Ia0322c4bebd4c5debcbfa4bb0902afbe581208b2


commit 8728f8e8705cfb6875a315aef85ec6004604e702
Author: Kohei Yoshida <kohei.yoshida@collabora.com>
Date:   Mon Jan 6 23:45:46 2014 -0500

    fdo#72645: Allow GETPIVOTDATA to get result from leaf node of result tree.
    
    Change-Id: I0fc1fd069440ed6fee378fc2dfd2ed761afbdeab

commit 17b00767948f7add229ec589c06cd8c898032ffa
Author: Kohei Yoshida <kohei.yoshida@collabora.com>
Date:   Tue Jan 7 00:48:10 2014 -0500

    fdo#72645: Case-insensitive string comparison in GETPIVOTDATA.
    
    Change-Id: Ibdb2b7ab2bae03875a3462816e860f58d9076457
Comment 4 Robinson Tryon (qubit) 2015-12-13 11:13:21 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]
Comment 5 Markus Mohrhard 2016-04-10 04:27:29 UTC
Is this still a problem in current master. At least I can't reproduce any performance problem for this document.
Comment 6 raal 2016-04-10 06:06:19 UTC
(In reply to Markus Mohrhard from comment #5)
> Is this still a problem in current master. At least I can't reproduce any
> performance problem for this document.

Hello Markus, original problem is resolved, I can not it reproduce anymore. 

But I can see problem with these steps: click on filter, deselect one item - now calc run at 100% CPU. I killed it after few minutes. In filter are 25000  items. This is not regression, I can reproduce it with 4.3.
Comment 7 m_a_riosv 2016-04-10 15:28:47 UTC
Still,
Win10x64
Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 1; OS Version: Windows 6.19; UI Render: GL;