Bug 83107 - FILEOPEN: LibO 4.3 permanently damages existing presentation files
Summary: FILEOPEN: LibO 4.3 permanently damages existing presentation files
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: x86-64 (AMD64) Linux (All)
: high critical
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords: possibleRegression
Depends on:
Blocks:
 
Reported: 2014-08-26 17:44 UTC by Callegar
Modified: 2015-12-15 10:57 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Demo file to trigger the incorrect behavior (223.85 KB, application/vnd.oasis.opendocument.presentation)
2014-08-26 17:44 UTC, Callegar
Details
Document damaged by libreoffice 4.3 (225.93 KB, application/vnd.oasis.opendocument.presentation)
2014-08-26 17:45 UTC, Callegar
Details
Test case that seems to work with LibO 4.3 (17.74 KB, application/vnd.oasis.opendocument.presentation)
2014-09-08 10:02 UTC, Callegar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Callegar 2014-08-26 17:44:30 UTC
Created attachment 105298 [details]
Demo file to trigger the incorrect behavior

Problem description: 

Since version 4.3, libreoffice cannot open presentation files prepared with previous releases of libreoffice correctly. Furthermore, files opened and subsequently saved with libreoffice 4.3 become similarly corrupted also for previous versions of libreoffice, hence libreoffice >= 4.3 ends up damaging existing libreoffice documents. The damages appear to be permanent, namely be not fixable by subsequent editing, meaning that libreoffice from version 4.3 builds incorrect data structures when reading existing impress files and subsequently outputs illegal odp files when saving them.

Thus the issue appears very serious because people might ruin their existing documents by editing them with libreoffice4.3 unless they have a backup.

The issue regards master pages and specifically the visual aspect of the bullet lists in the master pages. Two things happen:

1) The way in which these lists appear in the master pages and in the slides becomes inconsistent: lists are visually displayed in one way in the master page (e.g. with some color, some type of bullets, some spacing) and in another way in the slides.

2) The visual aspects of the bullet points (color, spacing, character or image used for the bullet point becomes uneditable).

The issue seems to be triggered by the presence of different master pages in the same document.

Instructions to reproduce are here provided with respect to two sample documents: demo_ok and demo_error.

demo_ok is a valid impress document prepared with libreoffice 4.2.

Steps to reproduce:

1. Open the document with libreoffice 4.2. Note how the bullet point appear in the slide. Close the document.

2. Open the document again with libreoffice 4.3. Note that the bullet points look different.

3. View the master page. Note that the bullets in the master page look different than in the actual slide.

4. Save the document as demo_error

5. Open demo_error with libreoffice 4.2. Note that things now go as in libreoffice 4.3. The bullet points are wrong in the slides, but still look correct in the master page.  Try changing the bullets from the master page. It is impossible.

Please, try to have this fixed soon since documents get permanently damaged. Also please update the release notes of 4.3 to indicate that it can damage impress documents.
Operating System: Ubuntu
Version: 4.3.0.4 release
Last worked in: 4.2.6.2 release
Comment 1 Callegar 2014-08-26 17:45:25 UTC
Created attachment 105299 [details]
Document damaged by libreoffice 4.3
Comment 2 Callegar 2014-09-06 13:12:54 UTC
Looks like this is still unconfirmed. I believe it is because people was busy with the Libreoffice conference.

Can someone check and confirm please? 

I recommend attention. Bug looks worrying. As is, valid documents are getting actively and permanently damaged.
Comment 3 ign_christian 2014-09-06 16:22:31 UTC
Hi Sergio.. 

Honestly I don't have proper understanding about this. Just tried to look your file in comment 0 with LO 4.2. And I saw something, I think, not usual in Slide Master. Second & fourth outline level in 'Predefinito' & 'Titolo1' is different.

Perhaps it could explain why second level bullet in LO 4.2 is square, and in LO 4.3 is minus sign.

Could you provide steps to reproduce the problem from scratch with LO 4.2 ?

*) Checked with LO 4.2.6.3 and 4.3.1.2 under Ubuntu 12.04 x86
Comment 4 Callegar 2014-09-08 09:09:22 UTC
Well, I must confess I have never thought of this as unusual.

I believed that the very purpose of having multiple slide masters was to let them be /different/.  And this has always worked perfectly in Libreoffice up to 4.2. And used to work just fine in Openoffice too. When working with slides, the program was applying to the current slide those styles defined in the corresponding master page.

This is also a very usual flow too, at least in the academy. One often needs to assemble in a single presentation some slides that have different sources. And if the original slides use different bullet point indentations, one wants to respect them, not to be compelled to reformat all of them by hand, just because the text does not fix or does not flow correctly. This means that different slides, corresponding to different master pages should be able to have different bullet point setting, with particular respect to their positioning.

In my opinion, it makes sense to have the styles belong to the master page, not to the document. I wonder what the ODP format says in this respect. Is the current behavior a mis-interpretation of the standard? Or was the previous behavior a mis-interpretation?

In any case can this be added to the release notes while in doubt, so that people who uses different master pages avoids LibO 4.3?

Let me remark it again. The issue here is not that LibO 4.3 does not /show/ the document as LibO < 4.3 used to do. The issue is that a roundtrip through LibO 4.3 permanently changes the presentation file in such a way that the old behavior cannot be obtained anymore, even in LibO < 4.3.  Even if the current behavior was the right one (and I don't think so, for sure it is more restricted and far less useful), people should have a chance to transition gracefully (or even to decide to stay at LibO 4.2 forever if they do not like it).

Now, I see that also Apache Openoffice is broken in this respect. So, I believe that the regression was introduced there and carried over to Libreoffice.
Should I report the bug to AOO rather than here?

In any case, since it is not only me to see this behavioral change, I am marking the bug as confirmed.
Comment 5 Callegar 2014-09-08 09:42:32 UTC
Just checked.

All Openoffice versions since Apache have the issue.
Comment 6 Callegar 2014-09-08 10:01:23 UTC
Furthermore, a funny thing is that if you start a document anew with LibO 4.3, the different styles in different masters, sorts of work (see demo2 attachment).

However, at a certain point it stops working and often LibO 4.3 ends up crashing.
Comment 7 Callegar 2014-09-08 10:02:52 UTC
Created attachment 105886 [details]
Test case that seems to work with LibO 4.3
Comment 8 Callegar 2014-09-13 13:59:34 UTC
Seems fixed in 4.3.2.1
Comment 9 Adolfo Jayme Barrientos 2014-09-13 17:24:17 UTC
(In reply to comment #8)
> Seems fixed in 4.3.2.1

Closing as WORKSFORME then.
Comment 10 Robinson Tryon (qubit) 2015-12-15 10:57:53 UTC
Migrating Whiteboard tags to Keywords: (possibleRegression)
[NinjaEdit]