Bug 62966 - TDE/CDE desktop needs cleanup and fixes
Summary: TDE/CDE desktop needs cleanup and fixes
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1.0.1 rc
Hardware: Other Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords: difficultyBeginner, easyHack, skillScript, topicCleanup
Depends on:
Blocks:
 
Reported: 2013-03-31 15:39 UTC by rezso
Modified: 2015-12-15 12:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
cleanup for CDE and TDE desktops (2.55 KB, patch)
2013-07-01 13:19 UTC, rezso 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rezso 2013-03-31 15:39:50 UTC 
It seems to me, that LO not supports CDE desktop.
But vcl/inc/unx/desktops.hxx contains it as known desktop, and the cde-open-url script always installed.

The tde-open-url script always (also with --disable-tde) installed.
              
Operating System: Linux (Other)
Version: 4.0.2.2 rc
Comment 1 bfoman (inactive) 2013-06-25 11:30:30 UTC 
(In reply to comment #0)
> It seems to me, that LO not supports CDE desktop.

Please elaborate.
Comment 2 rezso 2013-06-25 21:17:28 UTC 
- no .mk file, and any code for cde library under /vcl
- no configure test for cde
- no --enable-cde / --disable-cde configure option
For this reason I think, that the CDE support is removed.
But vcl/inc/unx/desktops.hxx contains it as known desktop, and the cde-open-url script is exists under /shell/source/unix/misc, and always installed.
Comment 3 Jean-Baptiste Faure 2013-07-01 05:06:27 UTC 
Set Michael in CC.

Hi Michael, do you have an opinion about that ?

Best regards. JBF
Comment 4 Michael Meeks 2013-07-01 09:30:37 UTC 
No idea; AFAIK there never was specific support for CDE - we just use the X backend for that; but - I imagine some integration points in .desktop files or there equivalent were needed to launch that thing.

Then again - since we don't really support solaris, which switched to GNOME long ago, I'd be well up for a patch to remove the CDE support :-)

All patches gratefully received :-)
Comment 5 rezso 2013-07-01 13:19:52 UTC 
Created attachment 81803 [details]
cleanup for CDE and TDE desktops

- remove DESKTOP_CDE from /vcl/inc/unx/desktops.hxx
- remove cde-open-url script and its installation
- add ENABLE_TDE condition to install tde-open-url script.
Comment 6 Michael Meeks 2013-07-01 14:41:20 UTC 
Nice work; pushed to master in your name; can you send a license statement to the dev list (no subscription required) that we can link into:

https://wiki.documentfoundation.org/Development/Developers

Thanks for contributing to LibreOffice ! :-)
Comment 7 rezso 2013-07-01 15:46:53 UTC 
Thank you, I sent my license statement.
My second „contribution” is a patch for bug46990 :)
Comment 8 Robinson Tryon (qubit) 2015-12-15 12:09:05 UTC 
Migrating Whiteboard tags to Keywords: (,EasyHack,DifficultyBeginner,SkillScript,TopicCleanup)
[NinjaEdit]