Bug 58038 - FORMATTING: can't format characters in text boxes or shapes *inside* charts (as created with the Drawing toolbar)
Summary: FORMATTING: can't format characters in text boxes or shapes *inside* charts (...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.8.0 inReleaseNotes:24.8
Keywords:
Depends on:
Blocks: Chart Toolbars Textbox
  Show dependency treegraph
 
Reported: 2012-12-09 03:18 UTC by Francisco
Modified: 2024-05-14 01:13 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
1) text toolbar in Draw (68.41 KB, image/png)
2013-06-10 12:06 UTC, Francisco
Details
2) Text toolbar working 0K in Calc (67.89 KB, image/png)
2013-06-10 12:07 UTC, Francisco
Details
3) Text toolbar in Chart (94.99 KB, image/png)
2013-06-10 12:07 UTC, Francisco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco 2012-12-09 03:18:37 UTC
Problem description: 
When making a chart and adding a textbox inside, it is not possible to use the classic format buttons for the text ("font name", font size, bold, italic, etc.) to the format toolbar. It is possible to add those commands, but they remain greyed while editing the text box. 

Formatting *is* possible through right-click - >character, or adding the "Character" button to the toobar. But not allowing to edit text direct from the toolbar is quite annoying. Besides, any other LibO app allows to format textboxes through its format toolbar


Steps to reproduce:
1. Open Calc, make a chart (any)
2. Add a text box and edit it adding any text.


Current behavior:
1. "Font name", "font size" nor any other typical format options doesn't appear appear automatically in format toolbar for editing text (IMHO it should).
2. Adding any of this commands to format toolbar is possible, but they remainsgreyed, not even displays the name of the font.

Expected behavior:
Formatting textboxes inside charts should be as easy as in any other  LibO app.
Comment 1 ign_christian 2013-06-10 08:43:29 UTC
It's possible now on LO 4.0.4.1 (Win7 32bit)
right-click Title/Subtitle > Format Title/Subtitle

Perhaps I misunderstood, please give more detailed steps
Comment 2 Francisco 2013-06-10 12:05:13 UTC
(In reply to comment #1)
> It's possible now on LO 4.0.4.1 (Win7 32bit)
> right-click Title/Subtitle > Format Title/Subtitle
> 
> Perhaps I misunderstood, please give more detailed steps

Hi Ign. Of course, you can format it, I stated that in the bug report. Besides what I'm reporting doesn't work for native chart titles (bug 39052) like chart title, what I'm reporting is that it is not possible to edit drawn textboxes (through Draw toolbar in Calc) only with the format toolbar.

For example, first screenshot shows Draw, with a textbox. Look at the format toolbar: there are many text commands: font name, bold, italic, centered, right... etc. This is shown in screenshot 1.

When adding a textbox inside Calc (or other LibO app), this commands works as expected, as shown in screenshot 2.

A textbox created with the same tool is not format-able through toolbar commands  inside any chart. This is shown in screenshot 3.


Adding one step more for clarifying: 
------------------------------------------------
Steps to reproduce:
1. Open Calc, make a chart (any)
2. Add a text box and edit it adding any text.
3. Try to edit the format of the text using *toolbar commands*, as in any other LibO app. 


Current behavior:
1. "Font name", "font size" nor any other typical format options doesn't appear appear automatically in format toolbar for editing text (IMHO it should).
2. Adding any of this commands to format toolbar is possible, but they remains greyed, not even displays the name of the font (as shown in screenshot 3).
-----------------------------------------------

Is it better now? :-)
Comment 3 Francisco 2013-06-10 12:06:42 UTC
Created attachment 80617 [details]
1) text toolbar in Draw
Comment 4 Francisco 2013-06-10 12:07:22 UTC
Created attachment 80618 [details]
2) Text toolbar working 0K in Calc
Comment 5 Francisco 2013-06-10 12:07:51 UTC
Created attachment 80619 [details]
3) Text toolbar in Chart
Comment 6 ign_christian 2013-06-11 02:36:49 UTC
Hello Francisco

I see..text box in chart can't be edited using 'Text Formatting' toolbar. Though it can be edited with double-clicking text box > mark the texts > right-click > Character. Is that what you mean?
Comment 7 Francisco 2013-06-11 03:34:07 UTC
(In reply to comment #6)
> Hello Francisco
> 
> I see..text box in chart can't be edited using 'Text Formatting' toolbar.
> Though it can be edited with double-clicking text box > mark the texts >
> right-click > Character. Is that what you mean?

Oh, yes. But more presicely "text formating commands", because that toolbar doesn't exist. I created it adding those commands, but you could add any of them, to any toolbar, and they wont work.

Now, I think it's more a "usability" issue rather "formating"... am I right?
Comment 8 ign_christian 2013-06-11 05:51:00 UTC
> Now, I think it's more a "usability" issue rather "formating"... am I right?
I think so :)

Lets mark this New enhancement, should we?
Comment 9 Francisco 2013-06-11 13:52:47 UTC
(In reply to comment #8)
> > Now, I think it's more a "usability" issue rather "formating"... am I right?
> I think so :)
> 
> Lets mark this New enhancement, should we?

It's 0K for me.
Comment 10 Francisco 2016-08-19 15:30:07 UTC
It's been like this since before the existence if LibO.
Comment 11 Xisco Faulí 2020-03-09 13:27:48 UTC
Please add keyword 'needsUXEval' and CC 'libreoffice-ux-advise@lists.freedesktop.org' if input from UX is needed.
Comment 12 Buovjaga 2024-05-07 15:26:09 UTC
How do you add a text box inside a Chart? I mean, does "inside" mean something special? Just drawing one on top of a chart, it works fine to format text via the toolbar.

Arch Linux 64-bit
Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
24.2.2-2
Calc: threaded
Comment 13 Stéphane Guillou (stragu) 2024-05-08 10:06:42 UTC
With bug 39052 now fixed, it is possible to change the character formatting of chart elements like titles.

However, if one inserts a text box by copying it from outside the chart and pasting it inside the chart, or by using the Drawing toolbar, the characters still can't be formatted.

Balázs, do you think that could also be done?
It makes sense to be able to do the same in text boxes used as annotations anywhere on the chart.
Comment 14 Balázs Varga (allotropia) 2024-05-08 12:04:07 UTC
> However, if one inserts a text box by copying it from outside the chart and
> pasting it inside the chart, or by using the Drawing toolbar, the characters
> still can't be formatted.
> 
> Balázs, do you think that could also be done?
> It makes sense to be able to do the same in text boxes used as annotations
> anywhere on the chart.

Hmm, thats interesting, I thought it has been working even without the fix in https://bugs.documentfoundation.org/show_bug.cgi?id=39052. I tried it and for me it works. I created a shape or textbox outside from a chart, then I add some text, but didn't format anything. Then I copied the textbox/shape into the chart then enter the custom textbox/shape and select a text part then right click Character... option and I can format the text. Or I did something differently?
Comment 15 Balázs Varga (allotropia) 2024-05-08 12:11:15 UTC
(In reply to Balázs Varga (allotropia) from comment #14)
> > However, if one inserts a text box by copying it from outside the chart and
> > pasting it inside the chart, or by using the Drawing toolbar, the characters
> > still can't be formatted.
> > 
> > Balázs, do you think that could also be done?
> > It makes sense to be able to do the same in text boxes used as annotations
> > anywhere on the chart.
> 
> Hmm, thats interesting, I thought it has been working even without the fix
> in https://bugs.documentfoundation.org/show_bug.cgi?id=39052. I tried it and
> for me it works. I created a shape or textbox outside from a chart, then I
> add some text, but didn't format anything. Then I copied the textbox/shape
> into the chart then enter the custom textbox/shape and select a text part
> then right click Character... option and I can format the text. Or I did
> something differently?

Or the problem is related that the toolbar option is not working in case of custom chapes/textboxes? In case of chart titles I added the Character... toolbar button in case of the text is formattable. I see now that the newly added Character... toolbar button is not activated in case we enter the custom shapes/textboxes in the chart, only activated in case of chart titles shapes. Probabaly this one can be easily fixed. :)
Comment 16 Buovjaga 2024-05-08 12:11:50 UTC
(In reply to Balázs Varga (allotropia) from comment #15)
> (In reply to Balázs Varga (allotropia) from comment #14)
> > > However, if one inserts a text box by copying it from outside the chart and
> > > pasting it inside the chart, or by using the Drawing toolbar, the characters
> > > still can't be formatted.
> > > 
> > > Balázs, do you think that could also be done?
> > > It makes sense to be able to do the same in text boxes used as annotations
> > > anywhere on the chart.
> > 
> > Hmm, thats interesting, I thought it has been working even without the fix
> > in https://bugs.documentfoundation.org/show_bug.cgi?id=39052. I tried it and
> > for me it works. I created a shape or textbox outside from a chart, then I
> > add some text, but didn't format anything. Then I copied the textbox/shape
> > into the chart then enter the custom textbox/shape and select a text part
> > then right click Character... option and I can format the text. Or I did
> > something differently?
> 
> Or the problem is related that the toolbar option is not working in case of
> custom chapes/textboxes? In case of chart titles I added the Character...
> toolbar button in case of the text is formattable. I see now that the newly
> added Character... toolbar button is not activated in case we enter the
> custom shapes/textboxes in the chart, only activated in case of chart titles
> shapes. Probabaly this one can be easily fixed. :)

Yes, see:

(In reply to Francisco from comment #0)
> Formatting *is* possible through right-click - >character, or adding the
> "Character" button to the toobar. But not allowing to edit text direct from
> the toolbar is quite annoying. Besides, any other LibO app allows to format
> textboxes through its format toolbar
Comment 17 Stéphane Guillou (stragu) 2024-05-08 12:51:15 UTC
(In reply to Buovjaga from comment #16)
> (In reply to Balázs Varga (allotropia) from comment #15)
> > > Hmm, thats interesting, I thought it has been working even without the fix
> > > in https://bugs.documentfoundation.org/show_bug.cgi?id=39052. I tried it and
> > > for me it works. I created a shape or textbox outside from a chart, then I
> > > add some text, but didn't format anything. Then I copied the textbox/shape
> > > into the chart then enter the custom textbox/shape and select a text part
> > > then right click Character... option and I can format the text. Or I did
> > > something differently?
> Yes, see:
> 
> (In reply to Francisco from comment #0)
> > Formatting *is* possible through right-click - >character, or adding the
> > "Character" button to the toobar. But not allowing to edit text direct from
> > the toolbar is quite annoying. Besides, any other LibO app allows to format
> > textboxes through its format toolbar
Interesting, I can't do that in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 505803e2cb4d60153be2218a17ede8e34d95b42e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

I tried:
1. Insert chart, stay in edit mode
2. Show Drawing toolbar with View > Toolbars Drawing
3. Use Insert Text Box from toolbar, draw text box in chart, click to edit, add some text, select it, right-click: no "Character" option. Format > Character is grayed out. Character button in Formatting toolbar is inactive.
4. Alternatively, exit edit mode; draw a text box outside chart; insert some text; copy text box; enter chart edit mode; paste; select some of its text > right-click: still no "Character" option. Format > Character still grayed out. Character button still inactive.

Are we using the same steps?
Comment 18 Balázs Varga (allotropia) 2024-05-08 15:54:09 UTC
> I tried:
> 1. Insert chart, stay in edit mode
> 2. Show Drawing toolbar with View > Toolbars Drawing
> 3. Use Insert Text Box from toolbar, draw text box in chart, click to edit,
> add some text, select it, right-click: no "Character" option. Format >
> Character is grayed out. Character button in Formatting toolbar is inactive.
> 4. Alternatively, exit edit mode; draw a text box outside chart; insert some
> text; copy text box; enter chart edit mode; paste; select some of its text >
> right-click: still no "Character" option. Format > Character still grayed
> out. Character button still inactive.
> 
> Are we using the same steps?

Ohh yeah, now I see. It looks like the original (chart title) implementation was affacted on this as well. Probabaly with this patch, https://gerrit.libreoffice.org/c/core/+/167366, it will make available the toolbar Character... format button for custom shapes as well.
Comment 19 Stéphane Guillou (stragu) 2024-05-09 05:15:15 UTC
(In reply to Balázs Varga (allotropia) from comment #18)
> Probabaly with this patch,
> https://gerrit.libreoffice.org/c/core/+/167366, it will make available the
> toolbar Character... format button for custom shapes as well.
I just tested the patch on Ubuntu 22.04 using the gtk3 VCL plugin, it works great!
- could format text in shapes and text box drawn inside a chart
- could use the context menu, the top menu, the toolbar button
- could also do it for a text box copied and pasted from outside the chart
- survives save and reload to ODS and XLSX
Comment 20 Commit Notification 2024-05-09 07:55:35 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/654150ffd05f43813332eedb969ab07fffa51b21

tdf#58038 - chart: make available format characters toolbar for

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Stéphane Guillou (stragu) 2024-05-14 01:13:46 UTC
Thanks Balázs!

In release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F24.8&type=revision&diff=750443&oldid=750442

Verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0dcaff6043e1f24ce0fa354dff80a86e40622247
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded