Bug 44732 - inking / PDF import cleanups
Summary: inking / PDF import cleanups
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2012-01-12 09:42 UTC by Michael Meeks
Modified: 2015-12-16 00:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2012-01-12 09:42:46 UTC
Currently we have to build two copies of 'basegfx' in order to link one dymamically, and one statically into the "PDF import" plugin. The latter used to be an extension we'd ship separately, but for LibreOffice this is always built-in so the separate library is un-necessary.

So: what needs doing ? :-)

The pdf importer is in sdext/source/pdfimport/ - we need to turn it, from an extension, into a normal component, and link against a non-static version of basegfx.

That involves a few tweaks to the makefile.mk to drop rules that create the .oxt and tweak the linking a little. [ the dmake includes that make all those rules work are in solenv/inc/ ].

It would be worth re-basing that top-level makefile.mk on eg. ucb/source/ucp/webdav/makefile.mk - that generates a component that will be bundled.

Then we need to tweak 'scp2' to distribute the shared library instead of the extension; git grep for 'dav' in scp2 to see how to do that.

Finally we need to register this built-in component in:

postprocess/packcomponents/makefile.mk

if it is enabled. Test compiling from clean is prolly a good idea to check it.

Thanks ! :-) it should clean the code, and shrink the install size too.
Comment 1 Florian Reisinger 2012-05-18 09:13:49 UTC
Deteted "Easyhack" from summary
Comment 2 Samuel Mehrbrodt (allotropia) 2013-02-11 15:38:44 UTC
In 4.0 PDF Import was turned into a core feature. Can this issue be closed?
Comment 3 Michael Meeks 2013-02-11 16:09:41 UTC
Yes - quite right; this is fixed now :-)
Comment 4 Robinson Tryon (qubit) 2015-12-16 00:24:58 UTC
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyInteresting,SkillCpp,TopicCleanup)
[NinjaEdit]