Bug 42974 - get the build process to auto-magically copy the Visual Studio CRT files to the right place
Summary: get the build process to auto-magically copy the Visual Studio CRT files to t...
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other Windows (All)
: medium trivial
Assignee: Mat M
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillScript
Depends on:
Blocks:
 
Reported: 2011-11-16 01:26 UTC by Noel Grandin
Modified: 2015-12-15 16:24 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noel Grandin 2011-11-16 01:26:38 UTC 
In order to make life easier when setting up a Windows machine to build the LibO sources, it would be nice if the build process automatically copied the Visual Studio CRT DLLs into the right location.

To get started, look in set_soenv.in in the root directory of the source tree and grep for "VC80.CRT".
At the moment, this file asks the user to manually install or find the VC80 DLL files.

On most machines, these files should already be present in
  c:/windows/winsxs/x86_Microsoft.VC80.CRT_<something>

It should not be hard to find the most directory (there may be several) and copy the DLL's to
  external/msvcp80

Note that it will also need to copy the manifest file from
  c:/windows/winsxs/manifests/x86_Microsoft.VC80.CRT_<something>
Comment 1 Mat M 2012-10-07 21:17:28 UTC 
(In reply to comment #0)
> In order to make life easier when setting up a Windows machine to build the
> LibO sources, it would be nice if the build process automatically copied the
> Visual Studio CRT DLLs into the right location.
> 
[...]
> It should not be hard to find the most directory (there may be several) and
> copy the DLL's to
>   external/msvcp80

When should we get it ?

Proposals are:
- configure
- autogen.sh 
- make bootstrap
- make fetch

I had configure in mind, coupling it with dev-www download of moz prebuilt if --disable-build-mozilla is on. IMO, we should not download during configure but could not find a better step in the build workflow.

What do you think ?
Comment 2 Mat M 2012-10-11 20:18:37 UTC 
Patch sent to mailing list
Comment 3 Mat M 2012-11-19 19:57:29 UTC 
Fixed in "master" :

http://cgit.freedesktop.org/libreoffice/core/commit/?id=67fca36dbecaf0d35322f930d6462ab0d4ea56c5

with message:
Better handling of well-know prerequisites under windows

Add moz prebuilt & msvcrt80 copy




(Sorry I missed the fdo# in the commit)
Comment 4 Robinson Tryon (qubit) 2015-12-15 16:24:52 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillScript )
[NinjaEdit]