Created attachment 193592 [details]
A sample XLSX with some sheets protected

The attachment has many sheets, some of them password-protected. It came from https://ask.libreoffice.org/t/retype-password/104531/, so it is a real-life user problem.

Saving it as ODS bring the "Re-type Password" dialog, which has [OK] button disabled, and no [Re-type] buttons immediately shown to user are enabled. This itself is bad: user needs to scroll the long list of sheets down to see the buttons that actually needs action. But coupled with the modern UIs that tend to make scrollbars less prominent (or even completely hidden), it confused the user even more, making them not understand what they are expected to do ("Can anyone explain what I’m being asked to do and why I’m being asked?"). So the first thing is: why there are the items there in the dialog, that *don't* need an action?

Then, it is not obvious which items were already processed. When I attempted removing the passwords for the first time, by clicking the enabled [Re-type] buttons, I thought I clicked them all, but obviously I missed some, because the [OK] was still disabled, until I went through the items again, seeing some items where I didn't choose an option. So, the dialog needs an indication of resolution state of items (say, a checkmark next to the item).

These two questions are the topics that need UX resolution in this bug. A possible follow-up (which require developers' investigation) is: is it possible to extend the ODS (maybe re-use the existing ODF features) to store the XLS(X) protection information there, instead of requiring the re-type? This was asked in bug 123877 comment 9.