Bug 157114 - The popup "Search Commands" should also search by submenu (such as Align Text, Track Changes)
Summary: The popup "Search Commands" should also search by submenu (such as Align Text...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 inReleaseNotes:24.2
Keywords:
: 142266 (view as bug list)
Depends on:
Blocks: HUD
  Show dependency treegraph
 
Reported: 2023-09-06 09:32 UTC by Dung.Saga
Modified: 2024-05-21 11:57 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dung.Saga 2023-09-06 09:32:29 UTC
Description:
Currently, the popup "Search Commands" only search by menu item. For example, searching for "right" yields "Format / Align Text / Right", but searching for "align" yields nothing.

I propose that it should also search by sub-menu (such as "Align Text"). This makes it easier to discover related actions in the same sub-menu. For example, the user may search for "align" to see all available align options (left, centered, right).

The same applies to sub-menu "Track Changes". The user who wants to turn on Track Changes function, but doesn't know the exact name of the command ("Record"). The user may try to search for "track" or "change". This improvement can show all commands in sub-menu "Track Changes".


Steps to Reproduce:
1. select "Search Commands" in menu "Help"
2. type "align" into the input box


Actual Results:
no command was found

Expected Results:
result should includes items in sub-menu "Align Text":
- Format / Align Text / Left
- Format / Align Text / Centered
- Format / Align Text / Right
- Format / Align Text / Justified


Reproducible: Always


User Profile Reset: No

Additional Info:
I tracked down the code in sfx2/source/commandpopup/CommandPopup.cxx and function MenuContentHandler::findInMenu. This looks like an EasyHack for me to start contribute to LibreOffice.
Comment 1 Tomaz Vajngerl 2023-09-06 10:33:57 UTC
Makes sense.
Comment 2 Heiko Tietze 2023-09-06 12:04:12 UTC
(In reply to Tomaz Vajngerl from comment #1)
> Makes sense.

Yes, it does.
Comment 3 Commit Notification 2023-09-07 08:52:22 UTC
Dung.Saga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7113a11a3cfa38a27dde4779b6565cf723b4b0d2

tdf#157114 The popup "Search Commands" should also search by sub-menu

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2024-05-21 11:54:28 UTC
Marking as fixed for Dung (no activity since that patch).

Works well in:

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

In release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F24.2&type=revision&diff=751638&oldid=751490

Thank you!
Comment 5 Stéphane Guillou (stragu) 2024-05-21 11:57:10 UTC
*** Bug 142266 has been marked as a duplicate of this bug. ***