Description: I mostly edit documents written by others. I make extensive use of English Sentence Checking features, which you keep turning OFF during most updates. Also, changes to those settings do not take effect until the document is reloaded. The user should at least be informed of this fact (if it must operate that way). As it is today, new settings are accepted, but the document still looks exactly the same, without explanation. Steps to Reproduce: 1.Apply LibreOffice update 2. 3. Actual Results: All English Sentence Checking settings reset to OFF (unchecked) state Expected Results: Retain my settings Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes
Created attachment 187117 [details] extract of "Lightproof" from msiexec verbose log upgrade 7.5.2 to 7.5.3 Confirmed Upgrade from 7.5.2 to 7.5.3 tdf builds The Tools -> Options -> English Sentence Checking The 17 values [1] recorded to registrymodifications.xcu are reset to defaults on initial launch after updates. Existing entries in the .xcu are not retained. Taking a verbose msiexec log I see the op to remove existing then reinstall full package, not clear ATM which is the 'English Sentence Checking' ID--no change to .xcu profile but functionally the feature gets reset to default on next launch after upgrade. Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded =-ref-= [1] as org.openoffice.Lightproof_en/Leaves/en as props oor:name= apostrophe cap dup ellipsis grammar mdash metric minus ndash nometric numssep pair quotation spaces spaces2 spaces3 times
@Mike, László since the .xcu is not changed during the upgrade (i.e. the previous Lightproof value stanzas remain at launch) is there some sort of "dirty" flag handling after Lightproof reinstall that is forcing opening with defaults? Could that be overridden to keep the user profile settings intact? And only a revisit to the Tools -> Options -> Language Settings -> English Sentence Checking for changes would actually modify the profile. Of course this could be moot as folks seem to like the new (at 7.4) LanguageTools on line integration. In other words, how viable for retention is the Lightproof_en grammar checking, maybe not worth any effort to adjust its handling in profile .XCU
Without looking into the code, my suspicion would be the check made when the build of the core changes (i.e., when program/version.ini's buildid differs from org.openoffice.Setup/Office/LastCompatibilityCheckID). If I'm correct, then simply changing the mentioned LastCompatibilityCheckID would trigger the problem on program restart.