Bug 154940 - Rename "Variable:" to "Custom:" in the Zoom & View Layout dialog
Summary: Rename "Variable:" to "Custom:" in the Zoom & View Layout dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium trivial
Assignee: sdc.blanco
URL:
Whiteboard: target:7.6.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks:
 
Reported: 2023-04-20 15:34 UTC by Tuomas Hietala
Modified: 2023-05-02 05:17 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-04-20 15:34:10 UTC
Description:
In the Zoom & View Layout dialog, there's an option called "Variable:", which allows the user to input a custom zoom factor.

Similar options elsewhere in LO are usually called "Custom:", so using that would be preferable for the sake of consistency and avoiding potential confusion.

Steps to Reproduce:
1. e.g. in Writer: View -> Zoom -> Zoom...


Actual Results:
The word "variable" is used.

Expected Results:
The word "custom" is used, in line with the rest of LO.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Rafael Lima 2023-04-20 17:39:19 UTC
+1

I've always found "Variable" to be a weird choice for this. "Custom" sounds better.
Comment 2 Heiko Tietze 2023-04-21 07:13:08 UTC
Code pointer: cui/uiconfig/ui/zoomdialog.ui
Comment 3 sdc.blanco 2023-04-27 15:33:19 UTC
https://gerrit.libreoffice.org/c/core/+/151117
Comment 4 Commit Notification 2023-04-30 22:25:08 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7837c4c7bd25202fd010fbf7b7f5a13388d62007

tdf#154940 change label from "Variable" -> "Custom"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-04-30 22:44:12 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/4e66412d1c72a51d6548c02baf8de9b4bbcfb92e

tdf#154940  update "Variable" label to "Custom"
Comment 6 BogdanB 2023-05-02 05:17:52 UTC
Custom is used in 7.6

Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fb3a6b82b55a298eabf8f431f1451dc826642acd
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded