Bug 154443 - UI: Page corners rendered incorrectly (grey squares)
Summary: UI: Page corners rendered incorrectly (grey squares)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 157294 (view as bug list)
Depends on:
Blocks: Icon-Themes
  Show dependency treegraph
 
Reported: 2023-03-29 10:57 UTC by bogdan
Modified: 2023-10-06 14:14 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot showing the problem (71.25 KB, image/png)
2023-03-29 10:58 UTC, bogdan
Details
The problem also appears in Print Preview mode. (63.64 KB, image/png)
2023-03-29 11:05 UTC, bogdan
Details
screenshot (157.80 KB, image/png)
2023-04-05 19:23 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bogdan 2023-03-29 10:57:39 UTC
Description:
The grey squares in the corners of the page, visible in the screenshot, don't appear when using other themes, including non-dark Colibre.

The squares appear in all four corners.

Steps to Reproduce:
1. Start with an icon theme other than dark versions of Colibre. The page is displayed normally.
2. Options - LibreOffice - View - Icon Theme - Theme: select Colibre (dark) or Colibre (SVG + dark).
3. Apply the change. The page is still displayed normally.
4. Restart Writer. The problem appears.


Actual Results:
Small grey squares appear in the four corners of the page.

Expected Results:
The page is displayed normally, as with other themes (Elementary or Breeze dark, for example).


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Flatpak
Calc: threaded

Linux Mint 21.1, Cinnamon, 4k display at 2x scaling.

Also tested the AppImage, same problem.
Comment 1 bogdan 2023-03-29 10:58:55 UTC
Created attachment 186281 [details]
screenshot showing the problem
Comment 2 bogdan 2023-03-29 11:05:21 UTC
Created attachment 186282 [details]
The problem also appears in Print Preview mode.
Comment 3 V Stuart Foote 2023-03-29 16:38:33 UTC
Confirmed, but have been seeing these dark corner marks with Colibre dark icon theme for quite some time.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4daeb21a5f533144fd6b3bc397a98f37e5b1dd4c
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 4 bogdan 2023-03-30 17:13:38 UTC
Additional info: the issue does not appear either in Impress, or in Calc's Print Preview.
Comment 5 BogdanB 2023-04-05 19:23:27 UTC Comment hidden (off-topic)
Comment 6 V Stuart Foote 2023-04-05 19:43:07 UTC Comment hidden (off-topic)
Comment 7 BogdanB 2023-04-05 19:52:15 UTC Comment hidden (off-topic)
Comment 8 V Stuart Foote 2023-04-05 20:16:11 UTC Comment hidden (off-topic)
Comment 9 BogdanB 2023-04-06 04:25:49 UTC Comment hidden (off-topic)
Comment 10 BogdanB 2023-05-13 18:51:04 UTC Comment hidden (off-topic)
Comment 11 V Stuart Foote 2023-05-13 19:21:32 UTC
(In reply to BogdanB from comment #10)
> I don't repro anymore. Somehow it was fixed.
> 
> Bogdan (reporter), do you reproduce it on a newer version?

I'm still seeing the gray marks on cornet of writer document background canvas with current nightly against 7.6.0, with default "system" appearance mode picking up UI in "dark" color theme, and the "Automatic (Colibre)" icon theme's rendering the dark variant.

When I force the appearance mode to "Light" and the "Automatic (Colibre)" icon theme shifts to its light variant the writer document background do not show the gray marks. So affecting the Windows dark theme support only.

It is not a Skia rendering issue as it also is visible with Skia diabled to use GDI+ default rendering.

=-testing-=

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: e08c910f9ee520ce00fe99d6dab9988138996ee3
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

likewise with release build
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 12 BogdanB 2023-05-26 18:29:41 UTC
Repro again
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: f3aab159f1c1e00c25e6b4ca1e50813bc343f4f3
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 13 Mike Kaganski 2023-07-11 15:03:19 UTC
It's page-shadow-mask.png, that should not be dark.
Comment 14 Mike Kaganski 2023-07-11 15:15:20 UTC
(In reply to BogdanB from comment #5)
> Created attachment 186498 [details]
> 
> Green in my case

Please note that *this* green rectangle is unrelated, specific only to dbgutil builds, and is intentionally drawn here:

https://opengrok.libreoffice.org/xref/core/sw/source/core/layout/layact.cxx?r=2f5bffaf&mo=85563&fi=2251#2239
Comment 15 Mike Kaganski 2023-07-11 15:25:50 UTC
Heiko, do you remember if there is a special case, that page shadow isn't shown in dark mode? (I don't remember where that code is) If so, then the bitmap from comment 13 could be simply blank in this mode?
Comment 16 BogdanB 2023-07-11 19:18:13 UTC
I found just this 3 occurrences for page-shadow-mask.png

/core/icon-themes/colibre/sw/res/
/core/icon-themes/colibre_dark/sw/res/
/core/icon-themes/karasa_jaga/sw/res/
Comment 17 Heiko Tietze 2023-07-12 09:31:24 UTC
(In reply to Mike Kaganski from comment #15)
> Heiko, do you remember if there is a special case, that page shadow isn't
> shown in dark mode?

Nope. But how about lcl_paintBitmapExToRect() called from SwPageFrame::PaintBorderAndShadow() in sw/source/core/layout/paintfrm.cxx?
Comment 18 Mike Kaganski 2023-09-17 19:16:12 UTC
*** Bug 157294 has been marked as a duplicate of this bug. ***
Comment 19 Stéphane Guillou (stragu) 2023-10-06 14:14:04 UTC
Reproduced in 7.4 too, when Colibre (dark) was introduced:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 122e9364ab297661ed91854f192c7a880eb08634
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded