Bug 153729 - UI: icons hidden in main menus should also be hidden in context menus
Summary: UI: icons hidden in main menus should also be hidden in context menus
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.7.3 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Context-Menu
  Show dependency treegraph
 
Reported: 2023-02-19 11:08 UTC by lol
Modified: 2024-04-17 13:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Calc icons in context menu and sheet menu (125.62 KB, image/png)
2023-02-19 11:08 UTC, lol
Details
Screenshots comparing menu in various Themes (123.66 KB, application/vnd.oasis.opendocument.graphics)
2023-02-19 12:40 UTC, Rainer Bielefeld Retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2023-02-19 11:08:09 UTC
Created attachment 185472 [details]
Calc icons in context menu and sheet menu

In the context menu of a sheet tab all entries have an icon. In the menu sheet there are some corresponding entries without an icon. See attached picture.

List of the missing icons:

delete sheet
rename sheet
hide sheet
show sheet
sheet tab colour
sheet events
right-to-left

Version: 7.4.5.1 (x64) / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 1 Rainer Bielefeld Retired 2023-02-19 12:37:44 UTC
REPRODUCIBLE with Installation of Version: 7.5.0.1 (X86_64)  
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 12; OS: Windows 10.0 Build 19044; 
UI render: default; VCL: win – Locale: de-DE (de_DE); UI: de-DE
Calc: threaded |  Elementary (SVG)  Theme  |  Normal UserProfile
Comment 2 Rainer Bielefeld Retired 2023-02-19 12:40:44 UTC
Created attachment 185473 [details]
Screenshots comparing menu in various Themes

Seems not to depend on selected Theme
Comment 3 Rainer Bielefeld Retired 2023-02-19 12:49:46 UTC
Already REPRODUCIBLE with Server Installation of Version: 6.0.7.3 (x64) 
Build-ID dc89aa7a9eabfd848af146d5086077aeed2ae4a5; CPU-Threads: 12; BS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL, Special devUserProfile

No obvious DUPs found with Query <https://bugs.documentfoundation.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs153729&sharer_id=19321>
Comment 4 Stéphane Guillou (stragu) 2023-03-05 11:38:31 UTC
Not reproduced on Linux:

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

So marking as Windows-specific.

Confirmed on Windows 10 like Rainer.
Comment 5 Maxim Monastirsky 2023-03-05 12:12:18 UTC
Hiding these icons was a deliberate change made in Bug 124649. I'm not sure why the icons are visible under kf5 as per comment 4, and I couldn't reproduce it myself with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: feda414f8b70f50a9f6745d2ce8828316d4711cd
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 6 Stéphane Guillou (stragu) 2024-04-16 14:48:00 UTC
(In reply to Maxim Monastirsky from comment #5)
> Hiding these icons was a deliberate change made in Bug 124649.
Thanks!
Icons visibility in menus in different VCL plugins depends on guidelines of different OS/DE, in order for LO to blend nicely. For example, kf5 is expected to show icons in menus, whereas gtk3 doesn't show any.

(In reply to Maxim Monastirsky from comment #5)
> I'm not sure
> why the icons are visible under kf5 as per comment 4, and I couldn't
> reproduce it myself
Well I'm not sure what I meant in comment 4. I can actually see the same as OP in 7.5 and a recent daily build, using kf5.

For the right-click menu, I guess it's OK to have more icons, as it's a smaller menu, whereas the top bar has a lot more items and needs to attract attention to the main ones.

Heiko, is this "Not a bug" then?
Comment 7 Heiko Tietze 2024-04-17 09:15:40 UTC
Bug 124649 aims to show icons only for the most important items. I would turn the issue around and investigate

(In reply to Maxim Monastirsky from comment #5)
> why the icons are visible under kf5

meaning to also not show icons on the context menu.
Comment 8 Stéphane Guillou (stragu) 2024-04-17 13:34:39 UTC
(In reply to Heiko Tietze from comment #7)
> Bug 124649 aims to show icons only for the most important items. I would
> turn the issue around and investigate
> (In reply to Maxim Monastirsky from comment #5)
> > why the icons are visible under kf5
> meaning to also not show icons on the context menu.
Just to make sure it's clear: I now see kf5 is the same as win, no distinction necessary.

OK, let's flip it then, and ask that icons hidden in main menus should also be hidden in context menus.

The Sheet main menu / context menu is a good example. Another example would be "Rename Page" in Draw: no icon in Page menu, icon in context menu in Page pane.