Bug 153030 - tiled rendering: top and footer text overlaps on docx
Summary: tiled rendering: top and footer text overlaps on docx
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Jaume Pujantell
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2023-01-15 07:24 UTC by jindam, vani
Modified: 2023-05-09 15:45 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot showing overlapping text on top and footer of docx (93.13 KB, image/png)
2023-01-15 07:26 UTC, jindam, vani
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jindam, vani 2023-01-15 07:24:28 UTC
Description:
top and footer text overlaps on docx

Steps to Reproduce:
1.open attachment 136298 [details] on bug 112443

Actual Results:
text on both top and footer are overlapping

Expected Results:
text on both top and footer should not overlap


Reproducible: Always


User Profile Reset: No

Additional Info:
repro: Version: 7.6.0.0.alpha0+ Build ID: d6c54b3d4ee7

i am wondering this is repro on desktop build?
Comment 1 jindam, vani 2023-01-15 07:26:15 UTC
Created attachment 184667 [details]
screenshot showing overlapping text on top and footer of docx
Comment 2 Michael Weghorn 2023-01-15 09:43:22 UTC
(In reply to jindam, vani from comment #0)
> repro: Version: 7.6.0.0.alpha0+ Build ID: d6c54b3d4ee7

Reproduced with same version of Android Viewer installed from F-Droid.

> i am wondering this is repro on desktop build?

Looks like an Android-specific issue. Looks good for me with the desktop version.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4ddfdeefe78e725b8d28fd60dbe32e7f4f054724
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 3 jindam, vani 2023-01-16 00:15:15 UTC
(In reply to Michael Weghorn from comment #2)
> (In reply to jindam, vani from comment #0)
> > repro: Version: 7.6.0.0.alpha0+ Build ID: d6c54b3d4ee7
> 
> Reproduced with same version of Android Viewer installed from F-Droid.

i am using fdroid version

> > i am wondering this is repro on desktop build?
> 
> Looks like an Android-specific issue. Looks good for me with the desktop
> version.

great

> Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 4ddfdeefe78e725b8d28fd60dbe32e7f4f054724
> CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: kf5 (cairo+xcb)
> Locale: en-GB (en_GB.UTF-8); UI: en-US
> Calc: threaded
Comment 4 Michael Weghorn 2023-01-17 08:51:37 UTC
Turns out this is a general problem when tiled rendering is used, and can be reproduced with gtktiledviewer as well:

    ./bin/run gtktiledviewer --lo-path=$(pwd)/instdir/program ~/temp/tdf153030/Bsp01.docx

This is a regression from

commit 0d29394598db2e336a9982cbb7041ea407b2bf6d
Author: Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>
Date:   Mon Feb 7 17:09:42 2022 +0100

    tdf#147126 sw: fix missing as_char anchoring of group textboxes
    
    which resulted lost (invisible) text content before
    implementing its support now.
    
    Cleanup to SwTextBoxHelper by removing its unneeded functions.
    
    testFDO78590 was commented out temporarily because it has a
    pure VML groupshape inside and it's converted to WPG during
    the test run resulting crash on reopening, because lack of
    its support in DocumentContentOperationsManager, trying to
    convert the content to a text frame inside a text frame.
    
    Regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
    "tdf#143574 OOXML export/import of textboxes in group shapes".
    
    Change-Id: Ic6ce3549d390ae763044f54e991f390677704396
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129627
    Tested-by: László Németh <nemeth@numbertext.org>
    Reviewed-by: László Németh <nemeth@numbertext.org>


Bibisected using the bibisect-linux-64-7.4 repo and llconv, this command:

rm -f /tmp/test_out.pdf; LO_PATH=$(pwd)/instdir/program/ lloconv -o pdf ~/temp/tdf153030/Bsp01.docx  /tmp/test_out.pdf && okular /tmp/test_out.pdf
Comment 5 Michael Stahl (allotropia) 2023-05-09 15:45:59 UTC
found that this was already fixed, thanks Jaume for fixing it!

also backported to libreoffice-7-5 as commit 5bab8fc3b9dd27c0e37cf9a62b1b27c2bf243788


commit 826b20b049449c9c335ce00c781cdb52e4ee0512
Author:     Jaume Pujantell <jaume.pujantell@collabora.com>
AuthorDate: Tue Mar 21 16:03:54 2023 +0100
Commit:     Andras Timar <andras.timar@collabora.com>
CommitDate: Wed Mar 22 16:49:49 2023 +0000

    Fix wrong layout of textbox in header
    
    In some cases the text box wasn't properly moved afeter it's position
    had been calculated. Also now when the shape and text element are
    brought together in the Z ordering, the one with higher Z moves down.
    
    Change-Id: I0512db4b6466532b5af4e3c091fd65bd0a416381
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149221
    Tested-by: Jenkins
    Reviewed-by: Andras Timar <andras.timar@collabora.com>