Bug 150196 - Impossible to assign percent format for incomplete data series in diagram
Summary: Impossible to assign percent format for incomplete data series in diagram
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.4.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-29 16:22 UTC by Andy Pillip
Modified: 2022-07-31 17:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Source spreadsheet to reproduce the issue (18.54 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-07-29 16:22 UTC, Andy Pillip
Details
Screencast of the issue (67.38 KB, video/webm)
2022-07-29 16:30 UTC, Andy Pillip
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Pillip 2022-07-29 16:22:59 UTC
Created attachment 181493 [details]
Source spreadsheet to reproduce the issue

I’m not sure if I’m using the correct terms here, as I’m on the German version.

So for several years now I’m having this issue which bugs me quite a lot now. When copying a diagram that displays values as % from Calc to Writer, the numbers get reformatted to decimal. In labels for data series as well as the axis. 

I can easily change the first series’ format by picking “Show as percent” from the firs level of settings. (Right click series, change data label formats or the like).

But when I try that for an incomplete series where at least one label has been deleted, it’s messed up. All format checkboxes are in intermediate state, selecting one does not change its state, but only enables the config button next to it, if it has one (number format, percent format).

When I choose percent format, disable usage of the source format, and pick a format, this will have no effect.

Only choosing number format, disabling usage of the source format, and picking a percent format in the advanced dialog will take effect.

So while preserving number formats from Calc to Writer would be nice as well, there is something messed up with the format options.


Version: 7.3.4.2
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded
Comment 1 Andy Pillip 2022-07-29 16:30:38 UTC
Created attachment 181494 [details]
Screencast of the issue

I’m trying to add the screencast. On Gnome it only shows some frames, but I believe the video itself is intact.
Comment 2 raal 2022-07-29 19:09:48 UTC
Confirm with Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: c4f7043c593823b8c5605e779371ff430659eb20
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

but I can check checkboxes in vclplugin=gen. Adding Caolán to CC.

@Andy, you can try it with env variable SAL_USE_VCLPLUGIN=gen, see https://wiki.documentfoundation.org/Development/Environment_variables

SAL_USE_VCLPLUGIN=gen soffice
Comment 3 Andy Pillip 2022-07-30 09:22:23 UTC
Thanks for the fast feedback.

Indeed, with gen UI it’s different:

* Initially, all checkboxes are in intermediate state.
* One can check “Value as percentage” and uncheck “Value as number”
* When confirming the dialog, the format is applied directly
* **But** the formerly deleted data point is re-created
Comment 4 Commit Notification 2022-07-31 17:49:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/730f6dac9eaad5b3ffda3032c184a671a9a16f72

Related: tdf#150196 can't change away from "indeterminate" state

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.