Bug 148836 - Categories in Customize keyboard dialog should be alphabetized
Summary: Categories in Customize keyboard dialog should be alphabetized
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Baole Fang
URL:
Whiteboard: reviewed:2022 target:24.2.0
Keywords: difficultyMedium, easyHack, skillCpp, topicUI
Depends on:
Blocks: Customize-Dialog-Keyboard
  Show dependency treegraph
 
Reported: 2022-04-28 11:44 UTC by sdc.blanco
Modified: 2023-06-18 18:04 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-28 11:44:20 UTC
Open Tools > Customize | Keyboard tab.
Look in Category window (lower left corner)

Actual: No apparent structure to entries.
Expected:  Alphabetic (as in Menu and Toolbar tabs)
Comment 1 Jim Raykowski 2022-04-29 00:26:49 UTC
code pointers:

     cui/source/inc/cfgutil.hxx 
     cui/source/customize/cfgutil.cxx
     
     In CuiConfigGroupListBox::Init add m_xTreeView->make_sorted()
     after m_xTreeView->thaw().
Comment 2 Mike Kaganski 2022-04-29 05:54:13 UTC
I believe that originally, that list was intended to:
1. Have its categories reflect the main menu order (File, Edit, View, Insert, ...);
2. Have some special categories in specific positions (All commands, Macros, Styles).

I have no personal preference for #1, but #2 IMO is important.
Comment 3 sdc.blanco 2022-04-29 06:56:04 UTC
(In reply to Mike Kaganski from comment #2)
> 2. Have some special categories in specific positions (All commands, Macros,
> Styles).
Relevant point.  

@Mike - a question came up (bug 131760) about whether commands could be categorized into the Styles categories. I believe at present this is not possible, because it is a special category  (dynamically populated with PS Styles, Page styles, etc.),  Simply for understanding, can you illuminate the situation in about adding .uno commands to the Styles category.
Comment 4 Mike Kaganski 2022-04-29 07:03:03 UTC
(In reply to sdc.blanco from comment #3)
> can you illuminate the situation in about adding .uno commands to the Styles category.

No I can't ;)
I believe Maxim is the expert here. My amateurish idea is that originally, all commands were categorized carefully; but then, in The Big Reorder (no idea if it is finished yet), everything got shuffled all over the menu, but without related categorization (I don't even know if changing categories would be safe compatibility-wise).
Comment 5 Mike Kaganski 2022-04-29 07:11:04 UTC
(In reply to sdc.blanco from comment #3)

By the way.
There are currently Style menus in all main modules (that weren't there originally); that might create some confusion (as you noted).

Initially, the Customization's Styles category simply listed the specific styles available for hotkeying, not the *commands* related to working with styles. That special category was meant in comment 2, and that should be distinct from commands relevant to working with styles (no specific suggestion how to do that).
Comment 6 Heiko Tietze 2022-04-29 07:40:06 UTC
(In reply to Heiko Tietze from bug 131760 comment 17)
> I hope it will become obsolete but wont do it myself. And I think it's not
> worth to put much effort in. Not too hard to find a command and browsing
> through categories is not a task.

Preferring a revamp as suggested in https://design.blog.documentfoundation.org/2015/01/22/how-to-make-libreoffice-customization-usable/ which also requires a new approach to shortcuts internally.
Comment 7 Heiko Tietze 2022-06-27 11:04:46 UTC
Let's do the simple sorting first. Code pointer in comment 1.
Comment 8 Hossein 2022-06-28 14:15:35 UTC
As Mike said in comment 2, I also think "All commands" should remain on top. This will also happen by sorting right now, but it will not be guaranteed in the future if the entries are changed. That is because we may have something less than "All" in the entries.

These are the entries, with the current order:

All commands
Application
View
Templates
Options
BASIC
Special Functions
Insert
Documents
Format
Edit
Navigate
Controls
Table
Drawing
Image
Data
Frame
Text
Numbering
> LibreOffice Macros
  >  My Macros
  >  LibreOffice Macros
> Styles
    Character
    Paragraph
    Pages
    Frame
    List
    Table
Sidebar Decks
Comment 9 Baole Fang 2023-05-24 00:33:07 UTC
Start working on this
Comment 10 Commit Notification 2023-06-18 17:05:22 UTC
Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/94bf26798bb973c7df26e2aa841099bb9cbaf3cb

tdf#148836: Alphabetize customize keyboard dialog

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.