Bug 145016 - UI: Selection of cells in left-side of the freezed area selects cells outside of the selection range
Summary: UI: Selection of cells in left-side of the freezed area selects cells outside...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-10-09 03:36 UTC by Kevin Suo
Modified: 2021-10-15 05:35 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2021-10-09 03:36:33 UTC
Steps to Reproduce:
1. New Calc, put cursor at cell B3.
2. Click the "Freeze Row/Column" toolbar button.
3. Select range A3:A10.

Expected Result:
It should indicate that cells A3:A10 are selected.

Current Result:
It is indicated that cells A3:B10 are selected.

This bug seems to only affect UI appearance, and not affecting editing, as when I paste sth into the selected cells only A3:A10 are pasted.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 418e56997c9e63a5bc669c1b79157b2a4dbf6a2c
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.3-CN
Calc: threaded
Comment 1 Kevin Suo 2021-10-09 03:38:45 UTC
Bibisected to range: 8ede76d9accc8e3b1ea2c8e332cbb373a1b4d9cf..2dfe1726d5262820c910d810b955ea73d3c7ae95

In which the following commit is suspicious:
author Szymon Kłos <szymon.klos@collabora.com>	2021-08-17 16:56:22 +0200
commit 57a628d540287c4bfa8251e50279f4879faa184d (patch)
    calc: get rects faster for simple selection

Adding Szymon Kłos to cc: could you please take a look? Thanks.
Comment 2 Kevin Suo 2021-10-09 06:29:26 UTC
Bisected to commit 57a628d540287c4bfa8251e50279f4879faa184d.
Comment 3 Szymon Kłos 2021-10-11 07:27:36 UTC
Yes, I will take a look
Comment 4 Commit Notification 2021-10-12 11:36:45 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ed4102a56981e5524a9992ef95e2c980db197fd

tdf#145016 calc: don't show selection from other split panes

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Kevin Suo 2021-10-15 05:35:08 UTC
Verified fixed in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1f9468fc29874eae5100317282ab8b395904406d
CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.3-CN
Calc: threaded