Bug 143894 - 7.2.0.3 release: external skia build fails with freetype 2.11
Summary: 7.2.0.3 release: external skia build fails with freetype 2.11
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-16 08:53 UTC by rezso
Modified: 2021-08-27 01:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rezso 2021-08-16 08:53:54 UTC 
If I try to build LO with freetype 2.11, the skia fails:

/var/uhubuild/work/compile/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:668:14: error: use of undeclared identifier 'FT_COLR_PAINTFORMAT_TRANSFORMED'; did you mean 'FT_COLR_PAINTFORMAT_TRANSFORM'?
        case FT_COLR_PAINTFORMAT_TRANSFORMED: {
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             FT_COLR_PAINTFORMAT_TRANSFORM
/usr/include/freetype2/freetype/ftcolor.h:505:5: note: 'FT_COLR_PAINTFORMAT_TRANSFORM' declared here
    FT_COLR_PAINTFORMAT_TRANSFORM       = 12,
    ^
/var/uhubuild/work/compile/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:669:60: error: no member named 'transformed' in 'FT_COLR_Paint_::(anonymous union at /usr/include/freetype2/freetype/ftcolor.h:1327:5)'; did you mean 'transform'?
            SkMatrix transform = ToSkMatrix(colrv1_paint.u.transformed.affine);
                                                           ^~~~~~~~~~~
                                                           transform
/usr/include/freetype2/freetype/ftcolor.h:1335:31: note: 'transform' declared here
      FT_PaintTransform       transform;
                              ^
/var/uhubuild/work/compile/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:763:14: error: use of undeclared identifier 'FT_COLR_PAINTFORMAT_TRANSFORMED'; did you mean 'FT_COLR_PAINTFORMAT_TRANSFORM'?
        case FT_COLR_PAINTFORMAT_TRANSFORMED:
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             FT_COLR_PAINTFORMAT_TRANSFORM
/usr/include/freetype2/freetype/ftcolor.h:505:5: note: 'FT_COLR_PAINTFORMAT_TRANSFORM' declared here
    FT_COLR_PAINTFORMAT_TRANSFORM       = 12,
    ^
/var/uhubuild/work/compile/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:768:74: error: no member named 'transformed' in 'FT_COLR_Paint_::(anonymous union at /usr/include/freetype2/freetype/ftcolor.h:1327:5)'; did you mean 'transform'?
                    colrv1_traverse_paint(canvas, palette, face, paint.u.transformed.paint);
                                                                         ^~~~~~~~~~~
                                                                         transform
/usr/include/freetype2/freetype/ftcolor.h:1335:31: note: 'transform' declared here
      FT_PaintTransform       transform;
                              ^
4 errors generated.

No option to disable the use of system freetype.
Comment 1 Julien Nabet 2021-08-16 10:55:39 UTC 
Luboš: thought you might be interested in this one since it's Skia specific.
Comment 2 rezso 2021-08-17 20:32:24 UTC 
skia m93 with a patch is good, but m94 *requires* freetype 2.11.