Bug 143212 - Copying and pasting pages whose master has grouped shapes (imported or native) unnecessarily creates a new master
Summary: Copying and pasting pages whose master has grouped shapes (imported or native...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2021-07-06 11:01 UTC by xordevoreaux
Modified: 2024-02-26 17:06 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (3.49 MB, application/vnd.oasis.opendocument.graphics)
2021-07-06 11:01 UTC, xordevoreaux
Details
original set of masters in the sample file (4.15 KB, image/png)
2021-07-06 11:02 UTC, xordevoreaux
Details
list of masters after copying and pasting (4.08 KB, image/png)
2021-07-06 11:03 UTC, xordevoreaux
Details

Note You need to log in before you can comment on or make changes to this bug.
Description xordevoreaux 2021-07-06 11:01:13 UTC
Description:
Windows LO draw will create new (useless) masters based on existing masters if a page whose master contains an SVG is copied and pasted.  

If I remove the SVG from the master pages, everything's fine.


Steps to Reproduce:
1. Open the attached sample file in Windows LO Draw
2. Expand the properties side bar on the right.
3. Select View, Gallery if the gallery is not showing
4. Notice in the properties sidebar that Master Page: has 3 masters
5. From the gallery, select either the 1st or 2nd slide and copy/paste.
6. Observe Master Page: again (the number of masters has not changed)
7. Select the 3rd slide from the gallery and copy and paste it.
8. Observe Master Page: again (there is now a 4th master)

Actual Results:
The first two pages do not have the SVG graphic on the master page (the white bar code).  Copying them works fine, no new masters added.

The third has an SVG of a white bar code. Copying and pasting that slide unnecessarily produces a new master.

The only way to get rid of it is to select Page, Master Page... and then re-select the proper original master.

Expected Results:
Regardless of the contents a master may have, no new masters should ever be created just for copying and pasting a page with any given master.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 79d31d08146afa0861ceb1705262411449e71ec7
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 1 xordevoreaux 2021-07-06 11:01:49 UTC
Created attachment 173377 [details]
sample file
Comment 2 xordevoreaux 2021-07-06 11:02:30 UTC
Created attachment 173378 [details]
original set of masters in the sample file

The list shows the number of masters prior to copying/pasting the 3rd slide.
Comment 3 xordevoreaux 2021-07-06 11:03:16 UTC
Created attachment 173379 [details]
list of masters after copying and pasting

Showing the newly created master (has an underscore after the name) once I've copied and pasted the slide whose master contains an SVG.
Comment 4 Telesto 2021-07-06 15:09:03 UTC
Repro
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c38d0d501f5eca648bdf0fd2914b57e06f505f7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Gallery = Page Pane
Comment 5 Telesto 2021-07-06 15:19:10 UTC
Also in
Version: 6.2.5.0.0+
Build ID: 92400e8df9f704ac4856dbb85d8551a0488fd334
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

and in
Version: 6.0.6.0.0+
Build ID: c30963b8b4bbbe42a24b97aafa161eff9d7ccdd4
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55
Locale: nl-NL (nl_NL); Calc: CL

and in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and in
Version: 4.3.0.4
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0

not in
4.1

Note: For older version.

1. Open the attached file
2. Copy slide 3 and paste
3. View -> Master
4. If there are 4 entry's it's wrong.. 3 OK
Comment 6 xordevoreaux 2021-12-03 16:22:25 UTC Comment hidden (obsolete)
Comment 7 xordevoreaux 2022-05-17 02:20:45 UTC
Still a problem in 

Version: 7.4.0.0.alpha1 (x64) / LibreOffice Community
Build ID: b871abad383583f02eb49c7e49aeae01f6941072
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 8 xordevoreaux 2022-10-07 16:45:26 UTC
Still a problem in 

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 9 raal 2023-04-19 18:17:59 UTC
Bisected with bibisect-43max.

There are only 'skip'ped commits left to test.
The first bad commit could be any of: 9e6599440da39be7061c4ec089347c3cb887ac72 1edce54be2a93b487c60ac6a05a913f17d278003 793162605c18acaa12bd779f83ff6cc9fab04de8 52b45843f08974fe8a8995fa12619ceb30998626 dfb306a31d2307085d764e604a285afa6081ec17 44285c5a1ae91f10a54a466f3be9b0b984017ed3 a4c6b7fc3a73bc17e1891334b8aab199f35c0f93 733201d3730ff912cfe76c91392c77aaf6d45249 9d8a3fc25b7710fd85bb8eecfb859f44eb665ead 83bf0c7719a6019e866c58034e9a9a475f7e3c25 a88383595684d65021a62903340e0f682c41e9eb 0bb57db8907778621b9d1a8fc3ca081b46be0873 a8e91c1f134eb9e59cf19fc70fc8b597bcde6e2a 41ea684df8a104b825e7cfeaf214b7fe1e4edce1 c3c687e81513cb5b559f477140b34156ec352ead 8220fbed17a14e1ef1fe3e033acd16befcfbe6f5 9525a18e2d0813cfb5c15aabaf76e9e5f4648b1c 54db6159906da7003653f4f8aaa905d5daf4ce5c e81ae62f8152dab2f1e75e439ab938ea9dc1da7d 5dce3b270f4e18fe596bb5d7c7ed04772d0b58e9 ebf3a59e265c9674e1655fe1a0f0486d4b79c095 782d06659837159a95cfdca2715644f0003daf82 f0959309969543ceb9f86ac118a9213bcb44d8c2 9c4436ec2a82f6b414970e4eaee876b7b9b49ebe b76d57df830230af4f240576ab25ee0c833a9321 469afd0c70f807c5ce135d090c73c1e780320827 ebb5e987167058a73054c7f59530362fbcc5ac0c 074b908db55ea187a10bbbcf45e443d8a5fee3e7 8223f33b0eb2ebd4204ea3a3212b21e1e10ea65d 458bf62083b8391c09e7115defdbb98215f0b0e9 617a2389eeb7c79027ffeeaa98efb7fe23a4fb09 62780f0581849bb425ae582ef4b7c295c4122944 cd55e5a19044abb0b6108e64eb035afb791c0c91 77cd1ae83262632fed0a47b5c924baae2e406aa9 e6c5211c1387d1e88ae118a5a05b34365672a21a 2cfa213d3c890d4ae531b3afafc2b7e340609a15 6ea6a6d8852e91665b245cf8a7bc38ae9825c26e a50212ce1c2df6249f6ed198c51de46ac71a4d1b dc2e0c20842716afe3c0a6e08ff12aa6be45ca38 05671f8960eed5ffc2b5a4389ab3819e4b2e9407 0b5a1ffab492cf2346e236474e6394c9f06e146c 54ff1b8cebb5559cd467619eecb2c382abeced94 f450d953c62727cbf684ac16c6325692514a5fb7 993668f68eb3256edf762f2b85f431f3c95dcd95 c2ae3b7b6de773a0c7b919797158fc1aadd27399 97fd15a38b0e5666f66f9d4292db83e40ae74f35 bf0d256e1c5878dd81da78ce94abe7ccd32fcebf 29b9797706ce3b0a2dab7cd1863c884e6c9d1503 ebcab630d3a1f4478073c1f2211c182e570500b7 b09f5207973604d717e0cb9034ff1565355cf6ab ead0b2fe0bb4cfd6484cd74264074fe3af3aaace 4d8c657652a0f516342ca77532e225f553affb48 ddec547db0d2198a85052af12c0189119359264f 2c85970b6bb591a2c67c34ef7f0f9295b88d6197 52cde3102a03a36bc76c2971f8af0864f0a9f788 3821f3505109f8d86da62578995ae46ca2689700 bcc621e8f232cb64e09b16937dc6d5d06e8fcb73 683719913f9efb4a2bdd1c0e1bd0e8d71d35985b 9830fec0b4fd5ccb51037549c06289a71944873d 03e98fa3010f5c921948eaf587fc081b726032e4 06331cf464b72f7cf03c23f614a40e2b112bb336 64cb6059ee542ec26f61a79fece3b6e7a1851dd2 85bc32710fba51b544b9a3ec8c5b09a8a5602613 c215de74816bf6310b66616c212b34d39d440bd6 d555d46178ac76ffcdf31b25311a7c6e7a9ea4d4 cace5fe8419e68c495e51cc3a5de96bee9d7840f
We cannot bisect more!
Comment 10 xordevoreaux 2023-04-19 22:44:21 UTC
Bummer. Hope you find it. Bit tedious to eyeball the master drop-down on the sidebar every single time I create a new page in Draw to see whether I need to flip it off of the newly created (and superfluous) master.

Good luck.
Comment 11 xordevoreaux 2024-01-22 11:42:06 UTC
Still a problem in 

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 12 xordevoreaux 2024-02-26 16:47:51 UTC
Still a problem in 

Version: 24.2.1.1 (X86_64) / LibreOffice Community
Build ID: 359ef544e625d2ffbfced462ab37bd593ca85fa7
CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded



Interesting Note: This egregious problem not only manifests with using imported SVG shapes, but after some experimentation, I've learned that it also happens with multiple native base shapes simply grouped together, with no additional editing, and placed on the master.
Comment 13 xordevoreaux 2024-02-26 16:52:08 UTC
Ungrouping objects regardless of source (native/imported SVG) **in some instances** is a decent work around, but for some complex imported SVGs with punch-outs and intersections, ungrouping them produces completely unusable results (they fall apart), so this work around is useful some of the time but not all of the time.