Bug 139076 - UI: Bulllet and numbering dialog image tab uses low resolution gif images
Summary: UI: Bulllet and numbering dialog image tab uses low resolution gif images
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.4.3.2 release
Hardware: All All
: medium normal
Assignee: andreas_k
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Impress-Bullet-Number
  Show dependency treegraph
 
Reported: 2020-12-19 20:11 UTC by Telesto
Modified: 2023-11-04 10:58 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot at 200 of bullets (images) (27.43 KB, image/png)
2021-01-13 09:51 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-19 20:11:41 UTC
Description:
UI: Bulllet and numbering dialog image tab uses low resolution gif images

Steps to Reproduce:
1. Open Writer
2. Format -> Bullets & numbering -> Image tab
3. Hoover over the items and notice gif path shown..

The simply look squeezed pixalated etc

Actual Results:
Pixelated, squeezed icons

Expected Results:
Some clean, crisp bullet images.. 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-19 20:13:07 UTC
Kind of clueless what the direction is based on bug 131713, bug 131224
However if this dialog being kept, please update the images
Comment 2 Heiko Tietze 2021-01-13 09:19:36 UTC
Appears crisp to me. What do you think, Rizal?
Comment 3 Telesto 2021-01-13 09:51:33 UTC
Created attachment 168845 [details]
Screenshot at 200 of bullets (images)

Count the pixels
Comment 4 Rizal Muttaqin 2021-01-13 11:06:33 UTC
Yes, the image(In reply to Heiko Tietze from comment #2)
> Appears crisp to me. What do you think, Rizal?

Looks pixelated to me. I thought Andreas has modernized all these images. Hasn't he?
Comment 5 andreas_k 2021-01-13 20:39:59 UTC
> Looks pixelated to me. I thought Andreas has modernized all these images.
> Hasn't he?

all that stuff is hardcoded somewhere, where you can't change them. I have new bullets which look good, but didn't work. Hours of work with no result.

I'll check maybe I can do something (work is already done).
Comment 6 Heiko Tietze 2021-01-18 12:22:13 UTC
The images are properly drawn per code. It starts at SvxSingleNumPickTabPage() with m_xExamplesVS->init(NumberingPageType::SINGLENUM) which does InsertItem() etc. The first couple of bullets are taken (4 by 2 in init() ). There is no low-res image drawn nor anything wrong.

Of course, if I take a screenshot and scale this graphic it ends up in rasterization.
Comment 7 Telesto 2021-01-18 13:27:24 UTC
(In reply to Heiko Tietze from comment #6)
> The images are properly drawn per code. It starts at
> SvxSingleNumPickTabPage() with
> m_xExamplesVS->init(NumberingPageType::SINGLENUM) which does InsertItem()
> etc. The first couple of bullets are taken (4 by 2 in init() ). There is no
> low-res image drawn nor anything wrong.
> 
> Of course, if I take a screenshot and scale this graphic it ends up in
> rasterization.

Disagree. These image are not hard coded.. or hard to find.. The tooltip shows the directory. Say LO5300RC2\share\gallery\bullets

So simply gallery items: take bludiamd.gif (it's the start icon)
Comment 8 andreas_k 2021-01-18 13:36:55 UTC
https://gerrit.libreoffice.org/c/core/+/109532
Comment 9 Commit Notification 2021-01-19 08:07:55 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4e1294b7d6f8de981147f15d4ca1b4e4853249eb

tdf#139076 update Bullet icons with sexy .svg icons

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-01-20 11:33:33 UTC
Andreas Kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/45e8dcec908878c07e3835fde7aa9db754d45ace

Revert "tdf#139076 update Bullet icons with sexy .svg icons"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2022-05-03 12:06:17 UTC
A polite ping to Andreas Kainz,
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks