Bug 138964 - Metric spinbutton doesn't react to change after key presses
Summary: Metric spinbutton doesn't react to change after key presses
Status: RESOLVED DUPLICATE of bug 135454
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks:
 
Reported: 2020-12-16 07:28 UTC by Aron Budea
Modified: 2020-12-16 09:04 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2020-12-16 07:28:54 UTC
The following is one example, but I think it's a generic behavior with similar welded spinbuttons.

- Insert a table in Writer.
- In the Table sidebar panel, erase a signifcant digit in 'Column width' field.

=> Nothing happens.

Before 7.0, the input was validated, and the table immediately got updated with the adjusted size, now this only happens when the focus leaves the spin field, the input handler isn't called during editing.

To be honest, I'm not sure if the new behavior is actually worse, because the automatic update of the field during editing could be annoying (eg. erase the "." in a < 7.0 version), but it seems more like an unintended side-effect: the input-handler of the control should be triggered, just the actual spinfield instances shouldn't specify one. But this is more like a generic UX principle to consider.

This particular change was introduced in the following commit, bibisected using repo bibisect-linux-64-7.0, but as I mentioned, the seems more like an implementation error in the spin field used. Either way, adding CC: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=76be71b2afa00ab66a543771c2c1a0894fa3a1ae
author		Caolán McNamara <caolanm@redhat.com>	2019-12-21 14:50:10 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2019-12-30 13:16:54 +0100

weld TableEditPanel
Comment 1 Caolán McNamara 2020-12-16 09:04:32 UTC
The new situation is intentional in the sense that this is how gtk (and most other toolkit) spinbuttons work, the value-changed is sent on clicking up/down or losing focus. These are downsides the an immediate update, especially if there other widgets whose value depends on the spinbutton's value

*** This bug has been marked as a duplicate of bug 135454 ***