Bug 137836 - The same (duplicate) keyboard shortcut in dialog window "Find and Replace"
Summary: The same (duplicate) keyboard shortcut in dialog window "Find and Replace"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.1.2 release
Hardware: All All
: medium trivial
Assignee: Diwanshu Mittal
URL:
Whiteboard: target:7.1.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2020-10-28 19:02 UTC by David
Modified: 2020-11-18 07:55 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2020-10-28 19:02:37 UTC
Description:
In dialog window "Find and Replace" (in Writer) is the same (duplicate) keyboard shortcut [Alt]+[C]. First usage is in check-box "Comments" and second in button "Close". I recommend change keyboard shortcut in check-box "Comments".

Steps to Reproduce:
1. run "LibreOffice Writer",
2. From main menu choose "Edit" and then "Find and Replace...",
3. press keyboard shortcut [Alt]+[C].


Actual Results:
Focus was changed to field "Comments".

Expected Results:
Press button "Close".


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no
Comment 1 V Stuart Foote 2020-10-29 14:45:56 UTC
Duplicated 'hot keys' (i.e. <Atl>+neumonic accelerators) are common and not really an issue. Though we have corrected some that are real problems.

I don't have much of an issue with presence on the F&R dialog, so => WF?

@Adolfo? Maxim?
Comment 2 Heiko Tietze 2020-10-30 12:30:17 UTC
Nice easyhack. 

svx/uiconfig/ui/findreplacedialog.ui  <object class="GtkCheckButton" id="notes">
Comment 3 Commit Notification 2020-11-18 03:04:43 UTC
diwanshu885 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/57f9fad565fed476b95cd53f2d025add577affe6

tdf#137836 Change the label from "_Comments" to "Comme_nts"

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.