Bug 136587 - FILEOPEN: Incorrect alignment in footer
Summary: FILEOPEN: Incorrect alignment in footer
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-09-08 20:50 UTC by Xisco Faulí
Modified: 2020-09-11 09:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.1 master (269.78 KB, image/png)
2020-09-08 20:50 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-09-08 20:50:48 UTC
Created attachment 165297 [details]
Comparison MSO 2010 and LibreOffice 7.1 master

Steps to reproduce:
1. Open attachment 62336 [details] from bug 50539

-> Check the footer. Page number should be center aligned and Printed aligned to the left. Instead both paragraphs have the same aligment. See screenshot

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 6b2eff7d69c6e14d89dd33eaa58c01d82c541266
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-09-08 20:51:45 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a59ecc3137cc59438cc2cf946223148b6d1a5600

author	Justin Luth <justin.luth@collabora.com>	2020-07-17 18:41:25 +0300
committer	Justin Luth <justin_luth@sil.org>	2020-07-18 07:53:19 +0200
commit a59ecc3137cc59438cc2cf946223148b6d1a5600 (patch)
tree efaf9ebff2ea1b0a8d53c7e6a68a9a79969e08d4
parent a83c69c291196a8325fd973df180e88ba9c625d3 (diff)
tdf#68326 writerfilter: default style type is paragraph

Bisected with: bibisect-linux64-7.1

Adding Cc: to Justin Luth
Comment 2 Justin L 2020-09-09 10:27:38 UTC
DBG_UNHANDLED_EXCEPTION in ApplyStyleSheets
    Styles could not be imported completely

A proper fix for this specific document would be to fix the import of the Normal paragraph style.

A generic avoidance fix is proposed at http://gerrit.libreoffice.org/c/core/+/102315 tdf#136587
Comment 3 Commit Notification 2020-09-10 05:32:29 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2dc30bd6ee88a2e3a1b4607c144f151e7329f3b9

tdf#136587 writerfilter: prevent exception in applyStyleSheets

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-09-11 08:13:38 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/46187510e383d62ee7bae8f8332322d7c3b0c61e

tdf#136587 rtf writerfilter: don't deduplicate yourself

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2020-09-11 09:03:59 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Justin Luth, thanks for fixing this issue!!
Comment 6 Justin L 2020-09-11 09:24:09 UTC
(In reply to Justin L from comment #2)
> A proper fix for this specific document would be to fix the import of the
> Normal paragraph style.

That's the commit in comment 4 - just for the record.