Bug 131924 - Crash in: SvtFileDialog::LinkStubDblClickHdl_Impl
Summary: Crash in: SvtFileDialog::LinkStubDblClickHdl_Impl
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.4.2 release
Hardware: All Linux (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-06 08:15 UTC by Luke Kendall
Modified: 2020-04-09 08:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature: ["SvtFileDialog::LinkStubDblClickHdl_Impl"]


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kendall 2020-04-06 08:15:30 UTC
This bug was filed from the crash reporting server and is br-a82d65b8-d414-4d9a-ac94-2a21f2afd084.
=========================================

Version: 6.3.4.2
Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: x11; 
Locale: en-GB (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

I had made approx 20 changes to a 130,000 word file.
I opened a copy made before the small changes.
I selected Compare Documents
LO crashed the instant I hit "Insert", after selecting the modified file for comparison.
Comment 1 Luke Kendall 2020-04-06 08:19:44 UTC
Oh, I should add that every time Writer crashes when Compare Documents:
1) When it restarts, the comparison has been made
2) Instead of the Manage Changes dialog only being open for the document being compared, *every* recovered file you had open gets its own (empty) Manage Changes dialog that must be closed.
Comment 2 Julien Nabet 2020-04-06 09:43:32 UTC
On which Linux distrib are you?
Could you give a try at 6.3.5 and if you still reproduce this at brand new 6.4.2 ?
Comment 3 Luke Kendall 2020-04-06 09:59:01 UTC
Ubuntu 16.04.6 LTS

LO:
Version: 6.3.4.2
Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: x11; 
Locale: en-GB (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

I just installed 6.3.5.2 and can confirm it crashed just the same:

crashreport.libreoffice.org/stats/crash_details/b405e1aa-5adb-4ed0-9653-48fb7bb10956

Downloading 6.4.2 now...
Comment 4 Luke Kendall 2020-04-06 10:04:03 UTC
Perhaps I should add I'm also running with env variable SAL_USE_VCLPLUGIN=gen
set, to work around the 100% CPU load bug in glib2 timer code.
(Since I need glib2-2.54.3-2 at least to fix that bug.)
Comment 5 Julien Nabet 2020-04-06 10:13:38 UTC
Interesting about gen rendering.

BTW, LO doesn't support gtk2 from 6.4 (see https://wiki.documentfoundation.org/ReleaseNotes/6.4#GTK.2B2_VCL_plugin).

I wonder if you shouldn't upgrade Ubuntu too. 20.04 will be released at the end of April but there's already 18.04
Comment 6 Luke Kendall 2020-04-06 10:18:33 UTC
Okay, the crash doesn't occur in 6.4.2.

Unfortunately the result is actually worse: it triggers https://bugs.documentfoundation.org/show_bug.cgi?id=102616

At least with 6.3, after the files are all recovered, the file comparison is useful.

With 6.4.2, instead of marking just 20 or so changes, the entire document is marked as different, consisting of many, many changes. So the compare document feature simply is utterly worthless.  But that's a separate bug, so if you want to close this one as Resolved, I'm fine with that.

(So it looks like 6.4.2 has undone an improvement for 102616.)

I plan to upgrade when my current book deadline is past (in May).
It's good to know a new LTS might be available by then (assuming they haven't done some Unity-like usability backwards step :-) )
Comment 7 Xisco Faulí 2020-04-06 11:37:58 UTC
Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive information before attaching it. 
See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.)
Comment 8 Luke Kendall 2020-04-06 13:11:50 UTC
Can you please clarify whether you want tme to take the time to produce sample documents to try to reproduce it in the older version of LO?

I assumed that as it does not crash in 6.4.2 you would prefer to resolve the bug.
Comment 9 QA Administrators 2020-04-07 03:29:38 UTC Comment hidden (obsolete)
Comment 10 Dieter 2020-04-07 15:29:58 UTC
(In reply to Luke Kendall from comment #8)
> I assumed that as it does not crash in 6.4.2 you would prefer to resolve the
> bug.

If it doesn't crash in 6.4.2 we can close this bug as RESOLVED WORKSFORME. Do you agree, Luke?

=> NEEDINFO

You mentioned other problems in comment 6, but they should belong to a different (or new) bug.
Comment 11 Luke Kendall 2020-04-09 06:20:13 UTC
I agree.
Comment 12 Dieter 2020-04-09 08:01:12 UTC
(In reply to Luke Kendall from comment #11)
> I agree.

=> RESOLVED WORKSFORME