Created attachment 157885 [details] Blurry Breeze SVG icons Choosing SVG versions of icon themes end up with blurry icons. The normal versions look better, even though they are not fully Retina quality (bug #128699) This is on a nightly after the fix of bug #122218, I also observed this problem before the bandaid fix Have not tested on non-Retina screen if the SVG icons are also rendered blurry there, only on a MBP 13" 2015 Version: 7.0.0.0.alpha0+ Build ID: 0cb4f304abf6f8dd6b40eb800788d2fe80581813 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Stephan: thought you might be interested in this one following your patch for tdf#122218
confirmed macOS 10.5.3, LO Version: 7.0.0.0.alpha0+ Build ID: 4caa7b790cf99eebbe47fc2e6a56124c42f1f3fc CPU threads: 4; OS: Mac OS X 10.15.3; UI render: default; VCL: osx; Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded
I presume this is blocked by bug 115439 (which is a more generic case), not vice versa.
I don't agree, this needs to be fixed before SVG is enabled as the default, at least on macOS. The normal icons are not retina, but looks better than the blurry SVG versions I don't want us to have an oversight here, the macOS version already has too many QC issues (e.g., Catalina, the broken font-rendering in many versions etc.)
(In reply to eisa01 from comment #4) > I don't agree, this needs to be fixed before SVG is enabled as the default, > at least on macOS. The way I understand is that the other bug is also used to track general code pieces missing for handling SVGs for icons properly in HiDPI mode (bug 115439 comment 7), but I don't know what actually has to be done.
This is true for Linux also, should a new bug be opened or this be renamed in order to generalize it?
I don't think SVG icons being rendered blurry is a generic issue on Linux, so that sounds like an environment specific issue. It would probably be better to open a new issue for that, to nail down when it happens
- Is this still the case for LO 7.5? - Can someone see the same thing before version 5.3? To see if its the same regression as bug 122113.
Still present in 7.5, yes I tried checking 5.2.7 and 5.3.7 (does not run on macOS 12 btw), but they don't bundle SVG icon themes on mac?
I have submitted the following fix for this bug. Fortunately, there was already some code for drawing the SVG icons at the same resolution as the system resolution but was unused on macOS. So I only needed to enable that code on macOS: https://gerrit.libreoffice.org/c/core/+/166867 Note: I also changed the default icon theme to be the SVG version of the existing default since the SVG icon themes will be higher resolution than the PNG icon themes.
Created attachment 193894 [details] Sukapura dark icons in top half, Sukapura dark SVG icons with fix in bottom half
Patrick Luby committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4ef5435df5560e6b6b061ce4053c71e2819bf51 tdf#130678 draw SVG icons at Retina resolution on macOS It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.