Bug 123937 - XML Filter settings dialog: Move buttons to the bottom
Summary: XML Filter settings dialog: Move buttons to the bottom
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Alexander Farrow
URL:
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, skillUI, topicUI
Depends on:
Blocks:
 
Reported: 2019-03-08 07:51 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2019-03-23 15:52 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the XML Filter Settings Dialog bug. (75.14 KB, image/png)
2019-03-19 14:47 UTC, Alexander Farrow
Details
Screenshot of the XML Filter Settings Dialog patch. (80.60 KB, image/png)
2019-03-20 14:10 UTC, Alexander Farrow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2019-03-08 07:51:43 UTC
The XML filter settings dialog (filter/uiconfig/ui/xmlfiltersettings.ui) has lots of buttons on the right.

The "Close" and "Help" button should be moved to the bottom. Close should be on the right and Help on the left.
Comment 1 Alexander Farrow 2019-03-18 19:24:54 UTC
I would like to fix this bug. I believe I have assigned the task to myself. This will be my first contribution to LibreOffice.
Comment 2 Alexander Farrow 2019-03-19 14:47:59 UTC
Created attachment 150102 [details]
Screenshot of the XML Filter Settings Dialog bug.

I have reproduced the bug on my system (LibreOffice Version: 6.3.0.0.alpha0+). 

Steps to reproduce:
1. Click "Tools".
2. Click "XML Filter Settings". 

I have also attached a screenshot of the XML Filter Settings dialog which shows the issue.
Comment 3 Alexander Farrow 2019-03-20 14:10:31 UTC
Created attachment 150119 [details]
Screenshot of the XML Filter Settings Dialog patch.

I have moved the "help" and "close" buttons to the bottom of the XML Filter Settings dialog.

A patch has been submitted:
https://gerrit.libreoffice.org/#/c/69468/

I've also attached a screenshot of the dialog with the patch applied.
Comment 4 Commit Notification 2019-03-23 06:19:33 UTC
Alexander Farrow committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f8251c40b4c512b6ea54ea2207a3816d8b925711%5E%21

tdf#123937 XML Filter Settings Dialog: Move "help" and "close" buttons

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.