Bug 122582 - Not possible to play/show a presentation
Summary: Not possible to play/show a presentation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-08 21:27 UTC by Nicolas Christener
Modified: 2019-12-09 17:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-01-08 21:27:25 UTC
Description:
Currently it's not possible to play/present a presentation.

Steps to Reproduce:
1. Create a presentation
2. Try to show the presentation in "full screen mode"

Actual Results:
Nothing really happens, there's an indicator saying "Downloading..." but nothing happens.

Expected Results:
The presentation shows in fullscreen mode and the user can navigate between the slides.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Aron Budea 2019-01-08 21:50:29 UTC
Confirmed using verion 0.1 (13).
Comment 2 How can I remove my account? 2019-02-20 16:48:01 UTC
Looking a bit at this now. The immediate issue is that the code wants to create a full-screen iframe for the slideshow, and that apparently is not possible in the webkit engine used on iOS (or Android, for that matter), says the internet.

But also otherwise the code will need re-work for the mobile app case, a bit like what was necessary for the image insertion code.

Just brainstorming here, but maybe instead of adding a full-screen iframe on the JavaScript side, what needs to be done is to in the native (Objective-C++) code create a new full-screen web view and in that then display the generated SVG for the slide show.
Comment 3 Aron Budea 2019-02-20 22:21:55 UTC
(In reply to Tor Lillqvist from comment #2)
> Looking a bit at this now. The immediate issue is that the code wants to
> create a full-screen iframe for the slideshow, and that apparently is not
> possible in the webkit engine used on iOS (or Android, for that matter),
> says the internet.
I don't know if it's related, but currently playing slideshow in online+Safari fails on iOS as well. Would be really nice if there was a way to fix that as well.
Comment 4 How can I remove my account? 2019-02-21 09:24:43 UTC
Yep, that full-screen iframe "feature" presumably causes that problem too. But the solution I am investigating will help the app only.
Comment 5 Commit Notification 2019-02-22 19:02:18 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/298d5ee4fae0c45e2dc3927a5399edc0257c75cd%5E%21

tdf#122582: Add ways to exit the slideshow in the iOS app

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-02-22 19:10:22 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/4dc340972c54f52631ea0d2bfd3d7eaba2f04e6c%5E%21

tdf#122582: Add slideshow functionality
Comment 7 How can I remove my account? 2019-02-22 20:01:34 UTC
Still need some way to exit the slideshow in the middle also without a hardware keyboard. Maybe simply a two-finger tap (which can be marketed as "pinch to close" even if actually any two-finger tap is enough)?
Comment 8 Commit Notification 2019-02-24 11:50:37 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/deb59e016854c76220bef59019717d7fe3944711%5E%21

tdf#122582: Add touch gestures to iOS app slideshow, also for exiting it

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 How can I remove my account? 2019-02-25 08:06:59 UTC
Implemented now in the master and cp-6.0 branches of core, and master branch of online.