Bug 121401 - Notebookbar F6 + Tab didn't work
Summary: Notebookbar F6 + Tab didn't work
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords:
Depends on:
Blocks: Notebookbar-a11y
  Show dependency treegraph
 
Reported: 2018-11-13 22:43 UTC by andreas_k
Modified: 2020-12-22 20:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2018-11-13 22:43:42 UTC
accessibility via keyboard.

with F6 you can swith to Notebookbar, the Problem is that you can't switch with tab to the different uno commands (GtkMenuToolButton) All GtkMenuToolButton's are in an sfxlo-NotebookbarToolBox widget. In svtlo-ManagedMenuButton it will work fine.

In LibreOffice Master (6.1 and 6.2) it didn't work in 6.0.x F6 + Tab work, BUT you can switch only to the first item in an sfxlo-NotebookbarToolBox element.

Notebookbar groupedbar compact
- F6 switch to NB focus
- Tab
- switch between different svtlo-ManagedMenuButton items but you can't move to GtkMenuToolButton in sfxlo-NotebookbarToolBox widget.

It should work that way that you can switch via TAB between the different uno commands like in Standard Toolbar.
Comment 1 V Stuart Foote 2018-11-15 02:57:00 UTC
Confirmed on Windows 10 Pro 64-bit (1803) en-US with
Version: 6.2.0.0.alpha1+ (x64)
Build ID: 20b2903354138f8ab19261fab74658fcf6af70e3
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-14_22:57:13
Locale: en-US (en_US); UI-Language: en-US
Calc: CL 

With talk of bringing the MUFFIN NB configurations out of Experimental this has to be corrected.
Comment 2 Jim Raykowski 2018-11-16 01:51:44 UTC
Hi All,

Here is a patch that adds Keyboard navigation to Writer NB contextual single interface:
https://gerrit.libreoffice.org/#/c/63458/

If testing a helpful patch to skip over tool boxes without any enabled or visible items is here:
https://gerrit.libreoffice.org/#/c/63457/
Comment 3 Commit Notification 2018-11-20 09:25:29 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/697c308431101c936bbaae25ea6f6efd162b9d9f%5E%21

tdf#121401 Keyboard navigation for Writer NB contextual single

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2018-11-20 21:49:23 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/12a878a2517cb2260a016ed1c7e5d056687416e9%5E%21

tdf#121401 writer keyboard navigation all  notebookbars

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-11-21 00:35:48 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/3df7ca1ee8f203bafa6298c1280ff47e7aca8eae%5E%21

tdf#121401 Keyboard navigation for Writer NB contextual single

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2018-11-21 06:06:50 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/de7d95da32e0515f89172bbb99e6c73b94f2c410%5E%21

tdf#121401 calc keyboard navigation all notebookbars

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Jim Raykowski 2018-11-21 10:50:42 UTC
Hi Andreas,

The following concerns the writer tabbed compact interface (notebookbar_compact.ui). 

File Tab:

Each control in the File tab is accessed by the tab key. Should not arrow keys be used for navigation within controls between separators? 

Home Tab:

Paste control is in a separate toolbox from cut and copy. Should it be in the same toolbox with cut and copy? 

There is no separator between Toggle Bulleted List, Toggle Number List and Increase Indent, Decrease Indent but they are in separate toolboxes. Should there be a separator between Toggle Number List and Increase Indent or should they all be combined into one toolbox?

Default Style combobox and Update Style button are in the same toolbox. An arrow key won't work to navigate out of combobox to get to the Update Style button. Tab key is required to navigate out of the combobox. This skips over the Update Style button. In this case a separate toolbox is required for each control in the group.

Insert Tab:

Insert Basic Shapes control is between separators with Curve and Line control but is in a separate toolbox.

Layout Tab:

Before Text Index, After Text Index, Above Paragraph Spacing and Below Paragraph Spacing do not grab focus to spin boxes. They flicker when tab key or arrow keys are used. I have been trying to figure this out.

Review Tab:

Comment is in separate toolbox from Reply Comment and Delete Comment but they are all within the same separators.

When Previous Track Change, Next Track Change, Accept Track Change and Reject Track Change are all disabled navigation does not skip over the toolbox. This can also happen in the Home Tab paste, copy, cut group. See patch to skip over tool boxes without any enabled or visible items here: https://gerrit.libreoffice.org/#/c/63457/

View Tab:

Should Navigator be in a separate toolbox from Rulers and Grid and separator between? 
Should there be a separator between Grid and Optimal?

Other:

There is not a way to access the toolbox containing Menubar, Open, Save, Undo, Redo, and Print controls and the hamburger Open Menu in this interface. I propose using Ctrl+Tab/Shift-Tab when focus is on a Tabbar tab name to cycle focus among toolbox, tabbar, and open menu.

I can provide patches for all these except for the Layout Before Text Index, After Text Index, Above Paragraph Spacing and Below Paragraph Spacing do not grab focus to spin boxes.
Comment 8 andreas_k 2018-11-21 13:13:52 UTC
(In reply to Jim Raykowski from comment #7)
> The following concerns the writer tabbed compact interface
> (notebookbar_compact.ui). 

notebookbar_compact.ui didn't get an final review only notebookbar.ui is out of experimental for now. I work now on notebookbar_groupedbar_compact.ui to bring it out of experimental.

> File Tab:
> 
> Each control in the File tab is accessed by the tab key. Should not arrow
> keys be used for navigation within controls between separators? 

The keyboard navigation stuff work with F6 + tab and with arrow keys you can switch between one tab group. That's the behaviour also in the sidebar. 

Yes I would prefer F6 + arrow keys.

about the other recommendations (thanks for that). In File tab you have each command in an separate NotebookbarToolBox so with F6 + tab you switch from one command to the next. As notebookbar_compact is very simple (cause it's only one row) I will suggest to have in the other tabbs also each command in an separate NotebookbarToolBox so you don't need F6 + tab + arrow key, you only need F6 + tab.

What do you think Jim?
Comment 9 Commit Notification 2018-11-21 22:42:27 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/791fb195ec12fe6910f5f9e02f69cd0db30161f1%5E%21

tdf#121401 calc keyboard navigation all notebookbars

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2018-11-22 00:00:17 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/194516e2af5e42fcb5127a50a1a495fc06997fb0%5E%21

tdf#121401 writer keyboard navigation all  notebookbars

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Jim Raykowski 2018-11-23 06:47:51 UTC
(In reply to andreas_k from comment #8)
> about the other recommendations (thanks for that). In File tab you have each
> command in an separate NotebookbarToolBox so with F6 + tab you switch from
> one command to the next. As notebookbar_compact is very simple (cause it's
> only one row) I will suggest to have in the other tabbs also each command in
> an separate NotebookbarToolBox so you don't need F6 + tab + arrow key, you
> only need F6 + tab.
> 
> What do you think Jim?

Sidebar uses F6, tab, arrows, space, and esc keys for keyboard navigation. F6 to enter sidebar, tab to navigate panel title bar and panel content tool boxes, arrows to navigate items in tool boxes and among panel titles and tab bar buttons, esc to move to panel title and to document. If all toolboxes in all notebookbars are made single item toolboxes, navigation of controls would be consistent in notebookbar but inconsistent with sidebar where control groups are separated by space as opposed to the vertical separator used in notebookbar ui's.

In writer Tabbed interface (notebookbar.ui), I find the same behavior as in Tabbed Compact (notebookbar_compact.ui) where Shortcuts tool box containing Menubar, Open, Save, Undo, Redo, and Print controls and Hamburger popup menu can not be reached using keyboard navigation. Tab cycle in Tabbed interface does not include the tab bar tab title as in Tabbed Compact[1]. The common method used to switch tabs in both Tabbed interface and Tabbed Compact interface is Ctrl+(Shift)Tab. Making controls tab navigation cycle include notebookbar tab title for Tabbed interface would provide a method by using Ctrl+Left/Right keys to navigate to the Shortcuts tool box and Hamburger menu. I can provide a patch for this if it is decided acceptable.

[1] To include tab bar tab title in tab cycle: 
/core/sw/uiconfig/swriter/ui/notebookbar.ui:1840
<object class="sfxlo-NotebookbarTabControl" id="ContextContainer">
            <property name="visible">True</property>
            <property name="can_focus">False</property>   <-- needs to be True to focus to tab title
Comment 12 andreas_k 2018-11-23 07:46:09 UTC
I submit the patch for can_focus True in sfxlo-NotebookbarTabControl it works really nice.
Change-Id: I5e4b3559bdb642a3e0d8a44ad744efe65b684e59

In writer tabbed NB (notebookbar.ui) I added shortcuts support to the tabbs, but it doesn't work. Do you know how it will work. (will add the shortcuts to the other apps if it will work in writer)

Thanks for your help, you improve the NB a lot.
Comment 13 Jim Raykowski 2018-11-23 09:54:26 UTC
(In reply to andreas_k from comment #12)

> In writer tabbed NB (notebookbar.ui) I added shortcuts support to the tabbs,
> but it doesn't work. Do you know how it will work. (will add the shortcuts
> to the other apps if it will work in writer)
> 

This patch provides a way to access shortcuts tool bar and hamburger menu using ctrl+left/right keys:

https://gerrit.libreoffice.org/#/c/63875/
Comment 14 andreas_k 2018-11-23 10:01:16 UTC
> This patch provides a way to access shortcuts tool bar and hamburger menu
> using ctrl+left/right keys:
> 
> https://gerrit.libreoffice.org/#/c/63875/

thanks please don't waite for an +1 from me cause I don't compile LibO so I can't test the patch

Would it be possible to have an patch that if there is NO menubar, the Alt Keyboard navigation focus switch from Menubar (cause it's not available) to NB?
Comment 15 Commit Notification 2018-11-23 21:22:36 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/953f8c7b53f159a702ee68ad970e58709696d66a%5E%21

tdf#121401 add can_focus to tabbs

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Jim Raykowski 2018-11-24 01:24:06 UTC
(In reply to Commit Notification from comment #15)
> andreas kainz committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/+/
> 953f8c7b53f159a702ee68ad970e58709696d66a%5E%21
> 
setting can_focus True for for the tab control (sfxlo-NotebookbarTabControl) is enough. No need to set can_focus True for tab labels (GtkLabel).
Comment 17 andreas_k 2018-11-24 09:03:46 UTC
Is it a bug, when there is an grayed out item and with F6 + Tab I come to this item, than Tab didn't switch to the next item. With F6 + Alt + Tab (so reverse order) there is no issue.

Open Writer in Tabbed Toolbar -> F6 at Home tab when Pase or cut, copy is grayed out -> F6 + TAB didn't work cause it stop at the first grayed out item.

Dirty fix, NO can_focus element on items that can be grayed out (not nice) or when there is an group of items, the first item should not be an element that can be grayed out (also not nice).
Comment 18 Commit Notification 2018-11-24 11:06:18 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/d2ddd9d9f062a458bb04c85cf031d2b2567d6fa9%5E%21

tdf#121401 add can_focus to tabbs

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2018-11-25 11:12:41 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/159b30d92f7a17f1d77417a2ed1836ea72699a0e%5E%21

tdf#121401 add shortcuts and Left2Right support

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2018-11-25 20:35:36 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/b06a46ad57e8868a10e055d4733b559283baff36%5E%21

tdf#121401 add shortcuts and Left2Right support

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 andreas_k 2018-12-08 23:06:07 UTC
So F6 + Tab work now in LibO 6.2