Bug 120420 - UI: Table dialog much wider than in previous versions
Summary: UI: Table dialog much wider than in previous versions
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-10-08 14:22 UTC by Xisco Faulí
Modified: 2018-10-15 14:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
comparison LibreOffice 6.0.6 and LibreOffice 6.2 (120.93 KB, image/png)
2018-10-08 14:22 UTC, Xisco Faulí
Details
how it looks after the patch (25.98 KB, image/png)
2018-10-11 08:16 UTC, Xisco Faulí
Details
How it looks on latest 6.2 (86.75 KB, image/png)
2018-10-12 16:31 UTC, BogdanB
Details
much better now (26.27 KB, image/png)
2018-10-15 14:36 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-10-08 14:22:08 UTC
Steps to reproduce:
1. Open writer
2. Insert a table
3. Go to Table - Properties

See comparison image

Reproduced in

Version: 6.2.0.0.alpha0+
Build ID: 4854acc7929ea58632c5d0f7f80a4adc3c62b8cd
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded
Comment 1 Xisco Faulí 2018-10-08 14:22:32 UTC
Created attachment 145473 [details]
comparison LibreOffice 6.0.6 and LibreOffice 6.2
Comment 2 Xisco Faulí 2018-10-08 14:23:45 UTC
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2018-09-10 09:04:43 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-09-10 13:16:13 +0200
commit 916260dcbe84fcde76ee66c752391123f44ea4da (patch)
tree 388a0202519e03422ecb4c577811ffc2acc2cb44
parent 0e8d0c725ed135dd7c95e6963e585326b2d97d3b (diff)
weld SwTableTabDlg

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara
Comment 3 Caolán McNamara 2018-10-08 16:30:58 UTC
seeing as the spinbuttons in your table page are so wide I imagine the problem is actually on the "column" page where there are six of those side by side
Comment 4 Caolán McNamara 2018-10-09 16:16:40 UTC
we could hide unused controls there so shrink it in the usual case. Or measure dialog width before showing the column entries and only put in as many as don't stretch the dialog.
Comment 5 Commit Notification 2018-10-10 13:37:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=853b84c307191c2d6fd0ac697328abb9ac8ef22a

tdf#120420 only show as much column widgets as don't distort the page width

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2018-10-10 13:39:06 UTC
I went with adding the comboboxes into the dialog until it starts to grow from its initial size and stop at that amount of widgets
Comment 7 Xisco Faulí 2018-10-11 08:16:22 UTC
Created attachment 145587 [details]
how it looks after the patch
Comment 8 Caolán McNamara 2018-10-11 20:10:56 UTC
each one is crazy wide, will have to find out why that is the case
Comment 9 Commit Notification 2018-10-12 11:34:11 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=95b91bafa519e45177689e9459e621370a34a40b

tdf#120420 fix for overwide Ubuntu 16.04 GtkSpinButtons

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Caolán McNamara 2018-10-12 11:36:22 UTC
They should be a saner size now, enabling fitting in 4 or 5 in that theme
Comment 11 BogdanB 2018-10-12 16:31:41 UTC
Created attachment 145658 [details]
How it looks on latest 6.2

I think it is solved. See the screenshot. Checked on 
Version: 6.2.0.0.alpha0+
Build ID: 144da6d5079bcd435e6637cb5cf95305f3ec1306
CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-10-12_02:13:01
Locale: ro-RO (ro_RO.UTF-8); Calc: threaded
Comment 12 Xisco Faulí 2018-10-15 14:36:31 UTC
Created attachment 145727 [details]
much better now

it looks much better now!