Bug 113859 - Can't select distance input field by tab on Area -> Shadow tab page
Summary: Can't select distance input field by tab on Area -> Shadow tab page
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: g.tarsoly
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2017-11-15 13:52 UTC by Tamás Zolnai
Modified: 2017-11-29 21:07 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2017-11-15 13:52:55 UTC
Description:
On Area -> Shadow tab page you can't travel to Distance input field by tab.

Steps to Reproduce:
1. Open Impress
2. Create a shape
3. Open Area / Shadow
4. Travel to Use shadow checkbox and push space (other options are available now.
5. Push tab -> Tab travels to Help button and skips other buttons

Actual Results:  
When shadow properties is enabled user can't select enabled options (e.g. distance)

Expected Results:
Distance input field should be selectable by tab


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.125 Safari/537.36
Comment 1 Tamás Zolnai 2017-11-15 13:55:30 UTC
Let's turn this into a easy hack. The code is here:
cui/source/tabpages/tpshadow.cxx
Check the SvxShadowTabPage class
Comment 2 Tamás Zolnai 2017-11-15 15:18:21 UTC
Some good notes about widgets:
https://wiki.documentfoundation.org/Development/WidgetLayout
Comment 3 Tamás Zolnai 2017-11-15 16:00:59 UTC
Some other notes:
Traveling by tab is mainly determined by the ui file. The ui file of this shadow tab page is here: cui/uiconfig/ui/shadowtabpage.ui.

I saw an other tab page in the same dialog where there is a similar solution (hiding a group of items by clicking on a button): Check Area -> Transparency tab and Gradient checkbox there. It works similar, when Gradient checkbox is checked the subitems are enabled, but in that case tab works as expected. So I suggest to compare the two ui files and try to find out what difference in their structure. The transparency page's ui file is here: cui/uiconfig/ui/transparencytabpage.ui.
Comment 4 Commit Notification 2017-11-29 14:30:35 UTC
geri1245 committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f26765e2dc8b7e6752a2cf6fbde3c45ab293f65

tdf#113859 Make it possible to select every widget with tab

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-11-29 21:07:27 UTC
geri1245 committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d81cbfdf987e44d4c59d9828369cf026f9b72da1&h=libreoffice-6-0

tdf#113859 Make it possible to select every widget with tab

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.