Bug 105888 - FILESAVE: CRASH when saving a spreadsheet with many comments ( steps in comment 4)
Summary: FILESAVE: CRASH when saving a spreadsheet with many comments ( steps in comme...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All Windows (All)
: highest critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: GDI-Limit
  Show dependency treegraph
 
Reported: 2017-02-09 18:51 UTC by K Udo Schuermann
Modified: 2020-02-24 15:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature: ["SalFrame::SetCallback(vcl::Window *,bool (*)(vcl::Window *,SalEvent,void const *))"]


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description K Udo Schuermann 2017-02-09 18:51:17 UTC
This bug was filed from the crash reporting server and is br-f0449b70-ead4-4735-a847-81c7753c3fde.
=========================================
Symptom: Suddenly unresponsive for a brief amount of time (fraction of a second to as long as 3-4 seconds), then abrupt shutdown. Recovery of documents following the crash has so far always been successful, with only minor (last minute or so) work lost.

Reproducible: No, happens rarely and seemingly randomly; Can go for days without a problem and with heavy work load; worst I've seen is 3 crashes in a day.

Cause: Unknown; I could be wrong, but it seems to happen when trying to select elements (a box, line/arrow) but I couldn't swear to it (happens too rarely, too unpredictably, and without any sign that things might be getting unstable).

Component: Have also observed such sudden crashes in Writer and in Calc (no idea if it's the same cause) mostly in Windows; Have occasionally (much more rarely) observed a failure in Linux, too.

Since when: Do not know what is the earliest version of LO when this happened, but it's been at least a year or two (i.e. 2015 onward). Frequency of crashes has not changed over time.
Comment 1 Xisco Faulí 2017-02-10 11:21:06 UTC Comment hidden (obsolete)
Comment 2 Markus Mohrhard 2017-02-13 15:34:53 UTC
@Xisco: All bug reports with the signature "SalFrame::SetCallback(vcl::Window *,bool (*)(vcl::Window *,SalEvent,void const *))" are related to running out of GDI references.
Kohei already fixed that recently and it will hopefully be in 5.3.1.
Comment 3 Xisco Faulí 2017-02-13 15:38:52 UTC
@Markus, ok, thanks for the info. I'll take it into account for the next time.
Comment 4 abma 2017-03-07 11:23:11 UTC
not sure if useful, i got directed to this bug report via a crashreport from 

https://bugs.documentfoundation.org/show_bug.cgi?id=76324

(stacktrace seems similar/identical)


to reproduce, open the document from #76324:
"calc document with many comments (~8k)"

mark all comments, copy and paste them. then try to save the document -> crash.
Comment 5 Xisco Faulí 2017-03-07 12:31:57 UTC
(In reply to Matthias from comment #4)
> not sure if useful, i got directed to this bug report via a crashreport from 
> 
> https://bugs.documentfoundation.org/show_bug.cgi?id=76324
> 
> (stacktrace seems similar/identical)
> 
> 
> to reproduce, open the document from #76324:
> "calc document with many comments (~8k)"
> 
> mark all comments, copy and paste them. then try to save the document ->
> crash.

Confirmed in

Versión: 5.3.0.3
Id. de compilación: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
Subpr. de CPU: 1; Versión de SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado: HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

on the other hand, if I open the same file in

Version: 5.4.0.0.alpha0+
Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
Locale: es-ES (es_ES); Calc: group

LibreOffice crashes right after opening the document
Comment 6 Xisco Faulí 2017-03-07 12:51:20 UTC
(In reply to Xisco Faulí from comment #5)
> 
> on the other hand, if I open the same file in
> 
> Version: 5.4.0.0.alpha0+
> Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
> CPU threads: 1; OS: Windows 6.1; UI render: default; 
> TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
> Locale: es-ES (es_ES); Calc: group
> 
> LibreOffice crashes right after opening the document

same behaviour reproduced with attachment 122489 [details] from bug 97698
Comment 7 Xisco Faulí 2017-03-07 13:43:31 UTC
it seems the problem in LibreOffice 5.4 is diffent from this one. Reported as a different issue in bug 106385
Comment 8 Xisco Faulí 2017-03-07 14:57:08 UTC
(In reply to Markus Mohrhard from comment #2)
> @Xisco: All bug reports with the signature
> "SalFrame::SetCallback(vcl::Window *,bool (*)(vcl::Window *,SalEvent,void
> const *))" are related to running out of GDI references.
> Kohei already fixed that recently and it will hopefully be in 5.3.1.

As Markus mentioned, I can no longer reproduce the crash in

Versión: 5.3.1.1
Id. de compilación: 72fee18f394a980128dc111963f2eefb05998eeb
Subpr. de CPU: 1; SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado: HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

Closing as RESOLVED WORKSFORME
Comment 9 b. 2020-02-24 15:56:20 UTC
confused: 

title says "FILESAVE: CRASH when saving a *spreadsheet* with many comments"

spreadsheets are in calc? 

affected component says: "*Draw*" 

op for bug says: "Have also observed such sudden crashes in Writer and in Calc" 

'also', thus initially not talking about Writer and Calc?, 

the samples talked about in c#4 and c#5 are calc spreadsheets ... 

can someone shed some light? 

thanks, 

b.