Bug 105365 - Clicking the font color button should apply the select font color instead of a color bucked
Summary: Clicking the font color button should apply the select font color instead of ...
Status: RESOLVED DUPLICATE of bug 105293
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.1 rc
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2017-01-16 11:33 UTC by Telesto
Modified: 2022-08-11 18:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-01-16 11:33:51 UTC
Description:
LibreOffice has two types of FontColor icons. A bucket version .uno:FontColor and one without bucket has the command .uno:Color.

The formatting toolbar in Writer is using the bucket version (.uno:FontColor). Impress and Calc are using the one without bucket (.uno:Color.)

Steps to Reproduce:
1. Open Writer
2. Type something 'ABC'
3. Click the Font color button in the toolbar or deck with default font color (red). Bucket appears

Actual Results:  
The default FontColor icon in the toolbar is the bucketed version.

Expected Results:
The default FontColor icon in the toolbar should be the one without the bucket (.uno:Color)


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in
Version: 5.4.0.0.alpha0+
Build ID: 99eed82939999d9a9689788a4134dd05d5c20c5a
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-14_23:37:40
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Telesto 2017-01-16 11:36:45 UTC
As requested a new bug report. https://bugs.documentfoundation.org/show_bug.cgi?id=88989#c13

Setting to NEW. Confirmation https://bugs.documentfoundation.org/show_bug.cgi?id=88989 

--> let's bring this to the attention of the design team
Comment 2 Heiko Tietze 2017-01-16 11:47:43 UTC
(In reply to Telesto from comment #0)
> Actual Results:  
> The default FontColor icon in the toolbar is the bucketed version.
> 
> Expected Results:
> The default FontColor icon in the toolbar should be the one without the
> bucket (.uno:Color)

Maybe I missed something, but where is the opposite to Writer in Impress or Calc?
Comment 3 Telesto 2017-01-16 12:03:42 UTC
@Heiko
1. Open Writer; Use a default profile
2. Type some text 'ABC'
3. Click on Font Color button in the deck or toolbar (not the color select arrow).
4. Type again some text. 'DEF'. Text will be black.
5. Move the mouse from the toolbar (or deck) to the page. Cursor will change in a bucked.

Compare it with Impress
1. Open Impress
2. Type some text 'ABC' in a textbox
3. Click on Font Color button (not the color select arrow).
4. Type some text again: 'DEF' (direct formatting is set; red color)
5. Move the mouse from the toolbar (or deck) to slide (no bucked)

It's like Regina Henschel said:
Writer has two kind of icons. One of them gives the bucket and the other doesn't. The bucket version is shown as default.
Please look in the customize dialog. The bucket version has the command .uno:FontColor; the one without bucket has the command .uno:Color.
Comment 4 Heiko Tietze 2017-01-16 15:06:07 UTC
Finally I got it. For those who want to compare .uno:fontcolor with .uno:color just modify a Notebookbar...

The function with bucket (.uno:fontcolor) applies the color to a selection that will be made afterwards (if text was selected before both functions works similarly). It doesn't toggles the feature on/off for text that is being entered, but the bucket is continuously shown and you have to press escape to leave the apply mode. 
Without bucket (.uno:color) it behaves like other properties such as bold/italic or bullets on/off and keeps the actual setting. 

My suggestion is to have the bucket on double click and use the plain function (.uno:color) by default for font color (meaning to unify both commands and remove one of them). Microsoft Word does the same, by the way. The highlight function should be different as it typically is not used for text that is being entered.
Comment 5 Maxim Monastirsky 2017-01-17 10:34:51 UTC
Hi Heiko,

(In reply to Heiko Tietze from comment #4)
> My suggestion is to have the bucket on double click and use the plain
> function (.uno:color) by default for font color
Not sure it's a good idea, as it will make the single click action apply with a delay. Double click is just two clicks one after another. When the first click occurs, we can't know in advance whether there will be a second one. So we have to wait some defined "double click duration", and only then apply the single click action, if there was no second click in the meantime.

> (meaning to unify both commands and remove one of them).
Note that we can't remove any of these commands for backward compatibility
(they might be used in user macros). Which one should be used for the toolbar
button, is another question.
Comment 6 Heiko Tietze 2017-01-17 10:55:24 UTC
(In reply to Maxim Monastirsky from comment #5)
> Not sure it's a good idea, as it will make the single click action apply
> with a delay. Double click is just two clicks one after another. When the
> first click occurs, we can't know in advance whether there will be a second
> one. So we have to wait some defined "double click duration", and only then
> apply the single click action, if there was no second click in the meantime.

Isn't it the same for clone formatting where you get the default immediately, and cloning becomes sticky after second click (the UI provides small feedback with the toggle button being delayed on single click).
Comment 7 Maxim Monastirsky 2017-01-17 11:14:20 UTC
(In reply to Heiko Tietze from comment #6)
> Isn't it the same for clone formatting
Yes, it's the same.

> where you get the default immediately
You don't get the default immediately there either. Single click only start a timer which waits the "double click duration". The code is here: http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/formatpaintbrushctrl.cxx#75
Comment 8 Telesto 2017-08-16 09:29:43 UTC
No repro
Version: 6.0.0.0.alpha0+
Build ID: f1a896c71c495bdef5861eb664581507b6b9b5bb
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-08-13_07:38:19
Locale: nl-NL (nl_NL); Calc: CL
Comment 9 Justin L 2022-08-11 18:57:07 UTC

*** This bug has been marked as a duplicate of bug 105293 ***