Created attachment 130281 [details] Example Writer document has a few lines and a button that launches sort()-macro. Works Before LO 5.2 beta1 SortDescriptor is used to set sorting parameters when sorting text from a macro ie. oVCursor = ThisComponent.getCurrentController().getViewCursor() oTCursor = oVCursor.getText.createTextCursorByRange(oVCursor) SortDesc = oTCursor.createSortDescriptor() prior to LO 5.2 beta1 (Delimeter) SortDesc(1).Value used to be an integer value presenting the delimeter character. From LO 5.2 beta1 (Delimeter) SortDesc(1).Value is expected to be an char value. As Starbasic macro language does not have native char type, it is impossible to change the Delimeter character from a Starbasic macro. ie. SortDesc(1).Value = 32 oTCursor.sort(SortDesc()) fails. Attached example file has a few lines and a button that launches sort()-macro. Before LO 5.2 beta1 the macro works and afterwards it does not. Please make the sort method accept Delimeter that has an integer value.
Confirmed in Version: 5.4.0.0.alpha0+ Build ID: 9a30cb2161506e003f14592d83075ab9d30516c1 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: group Regression introduced in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=66d2b72667792cb18b25805387824d636e2a455c..db5358764fdb1855ee6b401d6165ed65677bdfbe
@Aron, would you mind bisecting this one?
Why was the Version (earliest affected) changed to 5.1.0.0 alpha1 I tested that the example macro works on LO 5.2.0.0 alpha1 and 5.2.0.0 beta1 does not work.
Yes, bibisection points to a commit much later than that range. 7d4509440d07946fcef2f194beb4354f0f1ebd6c is the first bad commit commit 7d4509440d07946fcef2f194beb4354f0f1ebd6c Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sat May 7 12:20:50 2016 -0700 source e16fa715c43dcdf836ce8c400b6d54eae87b627d # bad: [86cb9d229718f48f9538032b80037238ea79e8a5] source 78223678b7513ffe46804cb08f2dc5bc899b2bab # good: [40ae184a3def17f40daf2f14088523fb143b376b] source 100eb15b4d8529d7a11d98a28742f31f0f792fa1 git bisect start '86cb9d229718f48f9538032b80037238ea79e8a5' '40ae184a3def17f40daf2f14088523fb143b376b' # bad: [1a9ea85803ce59716ba4e9fe3c97dbb2a2786d91] source e66c1a6f32fa682c60be672020f4ee8890b96a11 git bisect bad 1a9ea85803ce59716ba4e9fe3c97dbb2a2786d91 # bad: [cfd9a300a728c905540dae0ca340fa22b9b4a35f] source ace0b3bdec391aa170fe95c16a1a5d4a07d052df git bisect bad cfd9a300a728c905540dae0ca340fa22b9b4a35f # good: [a8583379abe7618c77e61641ca0c73201d1baf1e] source df90b5a1c9b602e524d0f92c7066c912f611b03b git bisect good a8583379abe7618c77e61641ca0c73201d1baf1e # good: [ec8a8089769ba0f078f8a00ea49e9cc4f0012cdc] source 04baf07416aefe7afccec8e45e620bf16643eadb git bisect good ec8a8089769ba0f078f8a00ea49e9cc4f0012cdc # bad: [90a855702060ee4a4aa02d8ed9c381fc29ed8cbd] source ee5850893e15acda1d7ce7cf17da7c80f2fa810a git bisect bad 90a855702060ee4a4aa02d8ed9c381fc29ed8cbd # bad: [1cc6e0cc6162e33634a2bbbea8a65cdd4c3318a9] source 46c87a5e8a52afd0060a399f71e8814cc120852c git bisect bad 1cc6e0cc6162e33634a2bbbea8a65cdd4c3318a9 # bad: [ffa87b205035f614e3a6c87d6be759ecc953f44c] source b73137aa58fe3a3562ec02f25114d769910b9740 git bisect bad ffa87b205035f614e3a6c87d6be759ecc953f44c # bad: [4f01540baa4e9850b7ac75bdec6f6b6d430acc7d] source 7ecaf61287606001eac9b3d76df95a0a900e11c0 git bisect bad 4f01540baa4e9850b7ac75bdec6f6b6d430acc7d # bad: [7d4509440d07946fcef2f194beb4354f0f1ebd6c] source e16fa715c43dcdf836ce8c400b6d54eae87b627d git bisect bad 7d4509440d07946fcef2f194beb4354f0f1ebd6c # good: [cb0d63e5a50364be107cdcb8b43d0a8d93766e96] source bc4d465484c67fa27d6c59807176d5f57155d9f5 git bisect good cb0d63e5a50364be107cdcb8b43d0a8d93766e96 # good: [34dbb96e9909d201bfaef437653e7ccf6a2b8228] source a2aea8bac55cef23297573733ba28f563f5aa791 git bisect good 34dbb96e9909d201bfaef437653e7ccf6a2b8228 # first bad commit: [7d4509440d07946fcef2f194beb4354f0f1ebd6c] source e16fa715c43dcdf836ce8c400b6d54eae87b627d
This bug started with the commit referenced below. Adding Cc: to David Ostrovsky. Please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=e16fa715c43dcdf836ce8c400b6d54eae87b627d author David Ostrovsky <david@ostrovsky.org> 2016-03-13 08:18:00 (GMT) committer Stephan Bergmann <sbergman@redhat.com> 2016-05-03 19:26:06 (GMT) "Handle wchar_t as native C++11 type on windows"
(In reply to Aron Budea from comment #5) > This bug started with the commit referenced below. Adding Cc: to David > Ostrovsky. Please take a look. > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=e16fa715c43dcdf836ce8c400b6d54eae87b627d > author David Ostrovsky <david@ostrovsky.org> 2016-03-13 08:18:00 (GMT) > committer Stephan Bergmann <sbergman@redhat.com> 2016-05-03 19:26:06 (GMT) > > "Handle wchar_t as native C++11 type on windows" Aron, what platform did you do the bibisection on? (It's always useful to state that, and also the name of the bibisection repo you used, just in case.)
My bad, it was bibisect-win32-5.2 on Windows 7.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b835cdb5ef4cebeae729b1edf2a773f4a582c0f tdf#105212: BASIC sets Delimiter prop to integer value It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=35001a92d5e414e93e8e8bbbc3999aeb8d8efcf2&h=libreoffice-5-2 tdf#105212: BASIC sets Delimiter prop to integer value It will be available in 5.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1eadd137ade5e2c4361990cce3f153e46110a1e9&h=libreoffice-5-3 tdf#105212: BASIC sets Delimiter prop to integer value It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-5-3-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=37fa60e6289b4c7ed88fd7b107af807211fd1ad9&h=libreoffice-5-3-0 tdf#105212: BASIC sets Delimiter prop to integer value It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I tested the fix in LO 5.3 RC3 and it solved the issue for me, thank you.
Setting to VERIFIED. Thanks for the feedback!