| Summary: | FILEOPEN: DOCX - RTL document incorrectly places frames, images, and shapes on the opposite side | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | mattip <matti.picus> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | aron.budea, fmalotaibi, jluth, kaplanlior, kelemeng, lukebenes, marklh9, ofirr.dev, rb.henschel, stgohi-lobugs, telesto, vmiklos, xiscofauli, zayed.alsaidi |
| Priority: | high | Keywords: | bibisected, bisected, filter:docx, regression |
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=43093 https://bugs.documentfoundation.org/show_bug.cgi?id=50301 https://bugs.documentfoundation.org/show_bug.cgi?id=94163 https://bugs.documentfoundation.org/show_bug.cgi?id=160833 |
||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104468, 136406, 155489 | ||
| Attachments: |
original docx right-to-left document
correctly formatted PDF document Simple test case for this bug. Bug85994-OLE-testcase.docx: Word2007 imports as OLE |
||
Created attachment 109075 [details]
correctly formatted PDF document
The correctly formatted document as PDF
Buggy behaviour with severals bugs reproducible with LO 4.3.3.2, Win 8.1: - Cloud is missing and cloud text is far right-aligned instead of left - In some parts the text format was changed - Number pictures are left-aligned instead of right - Degree numbers and latin characters pictures aligned at the wrong height - Geometric pictures are right-aligned instead of left - Parallelogram has a solid instead of interrupted line @Miklós: I don't know, but could this maybe be something you are interested in? ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.4 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-12-20 Still reproducible with LO 5.1.0.1, Win 8.1 Created attachment 121825 [details]
Simple test case for this bug.
The primary issue here is that images are being horizontally flipped. Images that belong on the left are going on the right and vice versa. This is a regression, as I cannot reproduce it on Version: 4.1.0.1.
In my simplified test case, the text box labeled left belongs on the left, while right belongs on the right.
bibisecting -last36onmaster: boxes displayed backwards. -last40onmaster: boxes cannot even be seen -last41onmaster: boxes seen properly -last42onmaster: boxes displayed backwards. Sorry - last comment somehow unintentionally saved. fixed between 40 and 41 # good: [5457c4d7182e205be50db8a2dacf0719e1b2f94e] source-hash-f48a576ff2c4f2ebd20b681d0c9b8233fe674a9d # first bad commit: [49b5642bdadfcc7dbe5c8af62340a7b66410a797] source-hash-1981819e81c1ad51b607d6af19e4e3776a74c75b Likely fixes: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d225318ead0154681982656bcd3e98011e022c34 OR https://cgit.freedesktop.org/libreoffice/core/commit/?id=becb244b4974609b0570e8db27d74e7e1179181c broken between 41 and 42 by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=aa52753785154f0e95fed559f613f5eae9105dcf - // Value should not always be 'true' - //OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(true)); - bool bSet = true; - - // Paragraph properties are not always 'true' by default - // For example - RTL layout of paragraph is by default 'false' (look in this link for 'sprmPFBiDi') - // http://msdn.microsoft.com/en-us/library/dd923496%28v=office.12%29.aspx - if (getId() == NS_sprm::LN_PFBiDi) - { - bSet = false; - } - - OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(bSet)); + OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(true)); Note to developers - make sure you check test1.docx frequently during development - the textbox placement is easily fixed by breaking the RTL setting. The RTL setting was NOT right in 4.1 - basically either the images/textboxes are right or RTL is right but not both simultaneously. NS_ooxml::LN_CT_PPrBase_bidi is the current version of NS_sprm::LN_PFBiDi I think the fix will have to be somewhere in the display, not in writerfilter. DomainMapper::getPositionOffset() seems to be the only potential modification point in writerfilter, but do we know anything about the shape itself at that point in order to adjust the Point? Created attachment 126973 [details] Bug85994-OLE-testcase.docx: Word2007 imports as OLE Bug85994-testcase.docx from Comment 5 imports as a GraphicImport. I tweaked it to add some visual features in Word 2007 and saved it - now it imports as an OLE object exhibiting the same symptom. Assuming bisected to imply bibisected, thus adding the latter. This is to make queries for "bibisected" not miss out bisected bugs. *** Bug 104393 has been marked as a duplicate of this bug. *** *** Bug 104673 has been marked as a duplicate of this bug. *** *** Bug 106138 has been marked as a duplicate of this bug. *** Based on the dupes this seems to be an issue affecting many people. Bumping the priority. Still happens in LibreOffice 5.4.1. Still happens in: Version: 6.0.0.0.alpha1+ Build ID: 6070dec9ca9a15587a2aece81f9ae1ab5ac0f8c4 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); Calc: group (Build from 2017-Nov-05 00:00) OS: Debian 64bit Stretch (Debian 9.2, with some backported packages) ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug still reproducible in Version: 6.2.0.0.alpha1+ (x64) Build ID: 485efed71807ecee5ce69fa556db98dbc78a97e5 Mark, You've been active in the RTL area recently. Is this issue something you'd be interested in looking at? *** Bug 114948 has been marked as a duplicate of this bug. *** I have test this bug with 6.4.0.0.beta1. It has still unresolved ! (In reply to Justin L from comment #8) > Note to developers - make sure you check test1.docx frequently Note that the comment 0 attachment is named test1.doc, but really it is a docx format. Comment on attachment 109074 [details] original docx right-to-left document (In reply to Justin L from comment #21) > Note that the comment 0 attachment is named test1.doc, but really it is a > docx format. Let's see if adjusting the details for it helps. Dear mattip, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug These files seem to look right now, according to linux-bibisect after: https://cgit.freedesktop.org/libreoffice/core/commit/?id=01dcc9a652ecfc65fb674b492afa6f58b0a846db author Miklos Vajna <vmiklos@collabora.com> 2024-05-02 08:42:25 +0200 committer Miklos Vajna <vmiklos@collabora.com> 2024-05-02 12:08:31 +0200 commit 01dcc9a652ecfc65fb674b492afa6f58b0a846db (patch) tdf#160833 DOCX import: use the DoNotMirrorRtlDrawObjs compat flag |
Created attachment 109074 [details] original docx right-to-left document The docx attatchment is not sidplayed properly, some objects are right-aligned when they should be left-aligned.