| Summary: | Can't reject format changes in "Accept or Reject Changes" dialog or via context menu | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | hessijames |
| Component: | Writer | Assignee: | László Németh <nemeth> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | badmofosteven, jorendc, kumara.bhikkhu, slkleo |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=50447 https://bugs.documentfoundation.org/show_bug.cgi?id=52391 https://bugs.documentfoundation.org/show_bug.cgi?id=58725 https://bugs.documentfoundation.org/show_bug.cgi?id=126206 |
||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 143063 | ||
| Attachments: |
An example file to demonstrate the problem
The example file in current version |
||
Thanks for reporting! I can confirm that using Mac OS X 10.8.2 LibreOffice 4.1.0.0.alpha0+ (Build ID: 699132c269a6c6d9e815fc582e2e6a106e46923) TinderBox: MacOSX-Intel@1-built_no-moz_on_10.6.8, Branch:master, Time: 2012-12-27_01:05:51 I can also reproduce it using the oldest LO version I have installed on Mac OSX. LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b So, I changed this bug to this version (instead of LO 4.0 branch). Hmm... It's more than a year now since this bug is reported. Still the same on 4.1.2.3. I'm beginning to find this annoying. It's bothersome when there's already character formatting before the recording formatting is made. So, to circumvent this bug by clearing direct formatting (the only way I know how at this point), all formatting is cleared, so that I've to redo the original ones. Eesh... So, I'm elevating the importance to major. Correction: "Clear Direct Formatting" doesn't work. I've to select, cut and paste as RTF. This clearly deserves a "major" label. ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.2 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-05-02 Tested it with libreoffice 4.4.2.2 on opensuse 13.2, bug still exists without any behavioural changes. With 6.1+: I. In "Accept or Reject Changes" dialog the "Reject" button is disabled when a "Formats" change is selected. II. Right-clicking on the text you changed and selecting "Reject" from the context menu is possible but behaves wrong: removes track change info but leaves the change. III: Selecting a non-"Formats" change in the "Accept or Reject Changes" dialog and clicking on the "Reject All" button gives similar result as II., change remains. With 6.1+: I. In "Accept or Reject Changes" dialog the "Reject" button is disabled when a "Formats" change is selected (this bug). II. Right-clicking on the text you changed and selecting "Reject" from the context menu is possible but behaves wrong: removes track change info but leaves the change (Bug 52391). III: Selecting a non-"Formats" change in the "Accept or Reject Changes" dialog and clicking on the "Reject All" button gives similar result as II., change remains (Bug 52391). ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug *** Bug 76772 has been marked as a duplicate of this bug. *** *** Bug 115772 has been marked as a duplicate of this bug. *** Created attachment 173168 [details] The example file in current version Looks okay-ish in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6805efdecb240fad8c82a5c1756a2a0e92f12b7d CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL After bug 52391 was solved, formatting changes can be cleared now from the Manage Changes dialog. There is no similar option in the context menu or the Track Changes sidebar. Also real tracking of formatting changes is still needed, i.e. storing and restoring the previous set of attributes (currently setting bold on an italic character and rejecting it also clears the italic formatting). This report can be kept as a reminder to change the dialog once that is supported. Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3a61cce54277fd12570103a191c50d9b37ef3dd3 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL |
Created attachment 72195 [details] An example file to demonstrate the problem LibreOffice keeps track of format changes (bold, font size, etc.) but it seems impossible to reject those changes. In the "Accept or Reject Changes" dialog the "Reject" button is disabled when a "Formats" change is selected but there are still two ways to try it anyway. Either by right-clicking on the text you changed in the main window and selecting "Reject" from the context menu. Or by selecting a non-"Formats" change in the "Accept or Reject Changes" dialog and clicking on the "Reject All" button. The effect is the same, LibreOffice looses track of the format changes but doesn't change the text to it's original state. I created a small example file, I hope you see what I mean.