Summary: | [FORMATTING] Incorrect text wrapping around drawing shapes (depending on zoom level) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | openoffice |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugs, cno, jbfaure, sasha.libreoffice |
Priority: | medium | Keywords: | regression |
Version: | 3.4.3 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:3.5.3 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 37361 | ||
Attachments: |
test case of wrap and page preview problem
proposed patch (already applied in master branch) Screenshot of incorrect wrapping in page preview |
Description
openoffice
2012-01-29 12:28:26 UTC
Additional information: - The problem has been reproduced on Windows and Linux - The problem does not occur when using images (with contour wrapping) instead of drawing objects - The problem seems to be related to SwContourCache (when disabling the contour cache, the problem disappears) or the data stored there Created attachment 58519 [details]
test case of wrap and page preview problem
Thanks for bugreport Reproduced in 3.5.1 on Fedora 64 bit and on 3.4.3 and 3.5.0 beta 3 on Windows XP But not reproduced in 3.3.4 on Fedora, therefore regression To reproduce bug: 0. Open attachment 1. pay attention how text placed to left and to right of rectangle 2. do File->Page preview 3. repeat step 1 4. close Page preview 5. repeat step 1 Bug may appear after step 2 or 4. Text seen in wrong place or appears in wrong place. Changing version to 3.4.3 as most early reproducible Pleased to see someone else also finds this bug annoying :) The bug is fixed on the master branch by the two commits b446a1fb30b5a7097824acfe6bbbb143f4284b03 and 84370b807279cd8336c3e77278bae42b904324b4 which change /sw/source/core/layout/pagechg.cxx. > The bug is fixed on the master branch by the two commits
> b446a1fb30b5a7097824acfe6bbbb143f4284b03 and
> 84370b807279cd8336c3e77278bae42b904324b4 which change
> /sw/source/core/layout/pagechg.cxx.
Just to clarify the state of affairs: so what is missing is just a backport of these two fixes to the LibreOffice 3.5.x branch(es), right? (I can't find the fixes in the 3.5 branch, but I may be wrong).
> Just to clarify the state of affairs: so what is missing is just a backport of
> these two fixes to the LibreOffice 3.5.x branch(es), right? (I can't find the
> fixes in the 3.5 branch, but I may be wrong).
Or, better question: Could you please test if the bug is still present in LibO 3.5.1 (and 3.4.5)? I have tried both versions, but I have problems to reproduce the bug clearly. Either it has been fixed in between even in these published versions (then we could close this bug report and be happy), or I am missing something (or the platform/OS has some influence: I am running LibreOffice on MacOS X 10.6.8 ...).
Sorry for so much comments, but: As far as I can see (but I'm not a C++ master!), the patch mentioned in Comment 5 is NOT in http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/core/layout/pagechg.cxx?h=libreoffice-3-5 and therefore the bug is NOT (yet) fixed on the 3.5.x branch. Right? Then please consider packporting the two patches to the 3.5.x branch ... Created attachment 58521 [details] proposed patch (already applied in master branch) Right, the bug is not yet fixed in 3.5.x, just in master; cf. http://comments.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/23158 However, the identical patch could also be applied to the 3.5 branch (if it is seen as an "important bug fix"). (In reply to comment #8) > However, the identical patch could also be applied to the 3.5 branch > (if it is seen as an "important bug fix"). Thanks for the suggestion! Mailed it to the developer list. Andreas Schierl committed a patch related to this issue. It has been pushed to "libreoffice-3-5": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2d7ce65af37195343ff74b9e01c60f4b86eb6ebe&g=libreoffice-3-5 ClrContourCache for SwAnchoredDrawObjects (fdo#45376) It will be available in LibreOffice 3.5.3. If this bug is fixed it should be better to change its status to fixed. I prefer to not do that myself because I am not able to reproduce the bug in LO 3.4: I can't see what is different between 3.4.6 and 3.5.3 wrt this bug report. So I can't verify if the bug is fixed or not. Please, could you attach a screencopy showing what is wrong in the preview for version 3.4.3. It will be useful if later we have to test a regression. Best regards. JBF Created attachment 60752 [details]
Screenshot of incorrect wrapping in page preview
The bug is fixed in LO 3.5.3 rc2 Thanks for additional testing *** Bug 34611 has been marked as a duplicate of this bug. *** |