Bug 153246

Summary: FILESAVE DOCX actual handle positions are not written to VML
Product: LibreOffice Reporter: Regina Henschel <rb.henschel>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: stephane.guillou
Priority: medium    
Version: 5.3.2.2 release   
Hardware: All   
OS: All   
Whiteboard: target:7.6.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107634, 128568, 136406    
Attachments: Fontwork shape "text plain" with not default handle position
Not default handle position by Word

Description Regina Henschel 2023-01-27 14:36:02 UTC
Created attachment 184960 [details]
Fontwork shape "text plain" with not default handle position

Open attached file and save it to docx.
Unpack the docx file and examine the document.xml file.
Notice, that the <v:shape> element has no 'adj' attribute. Such would have the actual values for the handle position.
Comment 1 Regina Henschel 2023-01-27 14:39:08 UTC
Created attachment 184961 [details]
Not default handle position by Word

The attached document shows, how Word writes the actual handle position into the 'adj' attribute of the <v:shape> element.
Comment 2 Stéphane Guillou (stragu) 2023-01-28 21:46:21 UTC
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 69c6f7bccec838b7288a25a29a83b7f782ba7586
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2023-01-28 21:50:02 UTC
Has been like that for a while, could reproduce with:

Version: 5.3.3.2
Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU Threads: 8; OS Version: Linux 5.15; UI Render: default; VCL: gtk2; Layout Engine: new; 
Locale: en-AU (en_AU.UTF-8); Calc: group
Comment 4 Commit Notification 2023-02-03 01:18:28 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a834bbad8295cba0ca88a91a524aad48640271ec

tdf#153246 VML export write adj attribute for Fontwork

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Regina Henschel 2023-02-03 01:26:42 UTC
The bug is fixed for the special case of preset Fontwork shapes. Prior to extending the fix to other preset shapes, bug 153296 needs to be solved. For other preset shapes the VML export is only a Fallback for MS Office versions older than 2010 and therefore has a low priority.