| Summary: | GTK3: menubuttons toggled states not visually consistent throughout the toolbars | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Jeff Fortin Tam <nekohayo> |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | normal | CC: | aron.budea, caolan.mcnamara, heiko.tietze, kainz.a, szymon.klos |
| Priority: | medium | ||
| Version: | 7.0.4.2 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=137840 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 102062, 107191, 112286, 120172 | ||
| Attachments: |
demonstration video
Screencast with Gen Screencast with gtk3 Screencast with kf5 |
||
Kf5 shows a frame around the control which remains there when the menu expands. Gen has a very strong "lowered" border indicator for GtkButtons and a less obtrusive but still visible frame for menu/toolbar buttons that expand into floating widgets. Gtk3 shows the frame around menu/toolbar buttons but reverts the menu buttons. Caolan, what do you think? Some one-shot functions such as the chevron to show the hidden toolbar/notebookbar items reverts back to the original state. That's correct IMO. Created attachment 179000 [details]
Screencast with Gen
Created attachment 179001 [details]
Screencast with gtk3
Created attachment 179002 [details]
Screencast with kf5
if this issue boils down to the notebookbar under gtk, then we are still not using real gtk widgets in the notebookbar, it's the remaining major thing that is "unwelded" and has all the theming issues associated with that. Patch https://gerrit.libreoffice.org/c/core/+/105265 was abandoned due to inactivity. Dear Jeff Fortin Tam, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug |
Created attachment 170600 [details] demonstration video In GTK (and various other toolkits), clicking on a menubutton will not only toggle the visibility of the associated menu or popover, but also set the button to be visually in a toggled "pressed" state. However, throughout LibreOffice's toolbar variants, including the "Tabbed" toolbar and particularly the "Groupedbar compact" toolbar, I can see at least three different visual styles when clicking various menubuttons: - Some do not show a pressed/toggled state at all (which looks very "wrong" :) - Some show a visual style specific to Libreoffice, very "rectangular" & flat - Some show a visual style that resembles GTK3's togglebuttons' toggled state Ideally they should all be in the 3rd category. The attached video demonstrates the various styles observed.