Bug 138769

Summary: FILEOPEN DOCX WordArt replacement image has incorrect height
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: aron.budea, jluth, nemeth, rb.henschel, szymon.klos, xiscofauli
Priority: medium Keywords: bibisected, bisected, filter:docx, regression
Version: 6.0.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=114308
https://bugs.documentfoundation.org/show_bug.cgi?id=137885
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 79512, 136406    
Attachments: Screenshot of the original document side by side in Writer 5.4 and 6.0

Description NISZ LibreOffice Team 2020-12-09 11:10:30 UTC 
Created attachment 167998 [details]
Screenshot of the original document side by side in Writer 5.4 and 6.0

attachment #166880 [details] contains a WordArt image at the top left corner.
This (rather its placeholder image) has incorrect height compared to Word: 1.66 cm instead of 2.59 cm. This affects the layout of the whole document.
Attachment #167937 [details] shows the document in Word and current Writer.

Steps to reproduce:
    1. open attachment #166880 [details]

Actual results:
“Rhif Number” WordArt has incorrect height of 1.66 cm

Expected results:
2.59 cm height of Wordart.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Also in:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Was good in:
Version: 5.4.0.3
Build ID: 92c2794a7c181ba4c1c5053618179937228ed1fb
CPU threads: 4; OS: Windows 6.2; UI render: default; 
Locale: en-US (hu_HU); Calc: CL

Additional Information: 

Bibisected using bibisect-win32-6.0 to:

URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ac38b5689458f6dc0da313fbd24b8b462cbcc78 
author	Szymon Kłos <szymon.klos@collabora.com>	2017-12-07 16:09:47 +0100
committer	Szymon Kłos <szymon.klos@collabora.com>	2017-12-08 21:18:13 +0100

tdf#114308 Export Watermark size as is

Adding CC to: Szymon Kłos
Comment 1 Xisco Faulí 2020-12-09 11:27:20 UTC 
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: fr-FR (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 Justin L 2021-11-11 12:54:20 UTC 
The problem seems to be with the section "if (!moTrim.has() || !moTrim.get())"
Comment 3 Justin L 2021-11-11 13:29:54 UTC 
(In reply to Justin L from comment #2)
> The problem seems to be with the section "if (!moTrim.has() ||
> !moTrim.get())"
This previously was only called when
getShapeName().match( "PowerPlusWaterMarkObject" )
but now is run regardless. That can't be right.

Szymon, please take a look and restrict to the specific use cases that are appropriate.
Comment 4 QA Administrators 2023-11-12 03:13:18 UTC Comment hidden (obsolete)
Comment 5 Regina Henschel 2023-11-12 12:29:39 UTC 
The height is still wrong in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 50add2043752c7b07beccef9a509bea6c09619f8
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL threaded

BTW, it is not an replacement image but fontwork shape, a custom shape with text path on.