Bug 123473

Summary: Tabbed NotebookBar misaligned buttons
Product: LibreOffice Reporter: Chris Sherlock <chris.sherlock79>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: chris.sherlock79, freedesktop.org, jluth, nekohayo, raal, vsfoote
Priority: medium    
Version: 6.2.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 102062, 107158, 107237    
Attachments: View menu
Tools menu
Tools tab - linux GTK3
Tools tab - macOS

Description Chris Sherlock 2019-02-15 01:55:22 UTC
Description:
There are buttons in the View and Tools tabs that are misaligned and have no gap between other buttons, it doesn't quite look right. 

Those buttons are:

View tab: the Rulers and Menubar buttons - they are too high, and there is no space between the buttons
Tools tab: Form control wizard button - again, too high and no gap between that and other buttons

Steps to Reproduce:
Enable Notetabbar

Actual Results:
UI looks wonky.

Expected Results:
The UI should look less wonky.


Reproducible: Always


User Profile Reset: No



Additional Info:
I am running this on Windows 7.
Comment 1 Chris Sherlock 2019-02-15 01:55:55 UTC
Created attachment 149303 [details]
View menu
Comment 2 Chris Sherlock 2019-02-15 01:56:28 UTC
Created attachment 149304 [details]
Tools menu
Comment 3 Durgapriyanka 2019-02-18 15:43:38 UTC
Thank you for reporting the bug. I can see the buttons have no space between each other, whereas the height is equal between all buttons.

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 raal 2019-02-23 07:29:56 UTC
With Version: 6.3.0.0.alpha0+
Build ID: 465939feb0e9c382e5581b53b72008979ece4807
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
There is space between buttons, but vertical align is bad.
Setting to new.
Comment 5 raal 2019-02-23 07:30:28 UTC
Created attachment 149539 [details]
Tools tab - linux GTK3
Comment 6 Maarten Brouwers 2019-03-28 20:21:26 UTC
Created attachment 150379 [details]
Tools tab - macOS
Comment 7 Maarten Brouwers 2019-03-28 20:23:36 UTC
Confirmed also on macOS; UI render: default, LO 6.2.2
Comment 8 Rizal Muttaqin 2020-02-24 18:42:21 UTC
Confirmed in 

Version: 7.0.0.0.alpha0+
Build ID: a545e25314d464c190d9d504d78ec6cb67ead4fd
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-02-20_15:31:00
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

& 

Versi: 6.3.4.2
ID Build: 1:6.3.4-0ubuntu0.18.04.1~lo2
Thread CPU: 4; OS: Linux 4.20; Render UI: baku; VCL: kde5; 
Locale: id-ID (id_ID.UTF-8); Bahasa-UI: id-ID
Calc: threaded
Comment 9 QA Administrators 2022-02-24 03:36:43 UTC Comment hidden (obsolete, spam)
Comment 10 Alec K 2023-06-21 16:02:36 UTC
Confirmed In:

Version: 7.5.4.2 (AARCH64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 10; OS: Mac OS X 13.4; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

CPU: Apple M1 Max
Resolution: 3456 × 2234 (bug occurs at all window sizes)

Enabled tab view with: View -> User Interface -> UI Variants: Tabbed

Buttons are misaligned and without gaps in the 'View' and 'Tools' tabs.
Comment 11 Jeff Fortin Tam 2024-02-03 19:27:28 UTC
I could also mention the "Clone" button next to the font family combobox, the "Merge and center cells" button next to the various rows/columns buttons in Calc's home tab, the "Open" button next to "Recent Documents" and "Open Remote", the "Save" button next to "Save As…" and "Save Remote", etc.

It's a systemic, generalized problem with layout in the LibreOffice notebookbars, so I don't think listing every occurrence of individual buttons where the problem occurs is necessary; rather, the toolbar's architecture should make it so that there is a minimum amount of spacing (3px?) enforced between columns/sections/widgets, and that the widgets' heights expand to fill the columns in a consistent way with other buttons or widgets (ex: Combobox/Menubutton and ComboboxEntry widgets).

From what I can see with version 24.2 (and older), the height problem (ex: buttons vs combobox) and spacing problems also affect the "Tabbed Compact" Notebookbar variant and GroupedBar AFAICT, not just the regular "Tabbed" Notebookbar.