Bug 120274

Summary: RTF: Asian and Complex Text Layout overlap in Font preview
Product: LibreOffice Reporter: Xisco Faulí <xiscofauli>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: michael.stahl, xiscofauli
Priority: medium Keywords: bibisected, bisected, regression
Version: 4.4 all versions   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=81944
https://bugs.documentfoundation.org/show_bug.cgi?id=96276
https://bugs.documentfoundation.org/show_bug.cgi?id=119599
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: Comparison LibreOffice 4.3 and LibreOffice 6.2 master

Description Xisco Faulí 2018-10-02 17:10:38 UTC
Steps to reproduce:
1. Go to Tools - Options - Language Settings and make sure Asian and Complex text layout are checked
2. Open attachment 144562 [details] from bug 119599
3. Modify any custom paragraph style and go to font tab

-> On the preview, the asian and complex text layout overlap

Reproduced in

Version: 6.2.0.0.alpha0+
Build ID: e9c1cbce903d325b1e19602d72765511589f5bf2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded
Comment 1 Xisco Faulí 2018-10-02 17:13:18 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f8e8e476aa0a5576234dbb4daac9dc299e044e61

author	Michael Stahl <mstahl@redhat.com>	2014-08-02 18:55:55 +0200
committer	Michael Stahl <mstahl@redhat.com>	2014-08-02 19:09:44 +0200
commit f8e8e476aa0a5576234dbb4daac9dc299e044e61 (patch)
tree af1749b82bd901e4058d67fe5a53528d148c36bc
parent 6defffea57ba803a47fd10d1496e0c5c477009c8 (diff)
fdo#81944: writerfilter: RTF import: don't drop fonts in stylesheet
The font definitions in the style sheet meet an untimely death in
StyleSheetTable::lcl_sprm(), which special-cases LN_EG_RPrBase_rFonts,
routing it into TblStylePrHandler.

Avoid this by sending style entries to the domain mapper in the same way
as the OOXML tokenizer, i.e., with paragraph and run properties nested
below CT_Style_pPr/rPr.

This reveals that the CT_Style_basedOn was wrongly handled as paragraph
property.

Bisected with: bibisect-44max

Adding Cc: to Michael Stahl
Comment 2 Xisco Faulí 2018-10-02 17:13:44 UTC
Created attachment 145332 [details]
Comparison LibreOffice 4.3 and LibreOffice 6.2 master
Comment 3 QA Administrators 2019-10-03 02:59:52 UTC Comment hidden (obsolete)
Comment 4 Xisco Faulí 2019-10-03 07:25:46 UTC
No longer reproducible in

Version: 6.3.3.0.0+
Build ID: a955330e052cc12c622982f38c5f5d138484013a
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Closing as RESOLVED WORKSFORME